Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node v14.15+ #2202

Merged
merged 7 commits into from
Dec 16, 2021
Merged

Support Node v14.15+ #2202

merged 7 commits into from
Dec 16, 2021

Conversation

jonathantneal
Copy link
Contributor

@jonathantneal jonathantneal commented Dec 14, 2021 •
edited
Loading

Changes

  • Updates all internal dependencies to expect Node v14.15+.
  • Updates all documentation to reference Node v14.15+.
  • Updates tsconfig.json files to reference Node v14.15+. 1

Testing

  • Updates CI to remove 12, and add 14, 16.

Docs

bump only

@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: f500899

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
astro Minor
@astrojs/parser Minor
@astrojs/prism Minor
create-astro Minor
@astrojs/renderer-preact Minor
@astrojs/renderer-react Minor
@astrojs/renderer-solid Minor
@astrojs/renderer-svelte Minor
@astrojs/renderer-vue Minor
@astrojs/astro-test-builtins-dep Minor
@astrojs/test-custom-element-renderer Minor
@astrojs/markdown-remark Minor
@astrojs/renderer-lit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) docs pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) 🚨 action Modifies GitHub Actions labels Dec 14, 2021
@netlify
Copy link

netlify bot commented Dec 14, 2021 •
edited
Loading

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: 07bef8b

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61bbc99146c7f80007fb9d3a

😎 Browse the preview: https://deploy-preview-2202--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Dec 14, 2021 •
edited
Loading

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 07bef8b

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61bbc99140a9e20008d189ab

😎 Browse the preview: https://deploy-preview-2202--astro-docs-2.netlify.app

natemoo-re
natemoo-re reviewed Dec 14, 2021
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'd want to wait to ship this other pending minor changes, maybe?

.changeset/new-hats-design.md Outdated Show resolved Hide resolved
.changeset/new-hats-design.md Outdated Show resolved Hide resolved
.changeset/new-hats-design.md Outdated Show resolved Hide resolved
scripts/cmd/build.js
// There's an issue with 'node12.20' compiling ESM to CJS
// so use 'node13.2' instead. V8 support should be similar.
target: 'node13.2',
target: 'node14',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me happy!

@jonathantneal
Copy link
Contributor Author

jonathantneal commented Dec 14, 2021 •
edited
Loading

@natemoo-re, because dependency updates can go stale pretty quickly (as I experienced last round), I would suggest separate PRs for dependencies, but this is not a strong opinion.

@github-actions github-actions bot added the feat: markdown Related to Markdown (scope) label Dec 14, 2021
FredKSchott
FredKSchott approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@FredKSchott FredKSchott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! FYI I just merged the regen lockfile PR so you may want to rebase off of main and re-regenerate your lockfile based off of that (or remove the svelte plugin update entirely from this PR, as discussed in Discord). Up to you!

natemoo-re
natemoo-re approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

FredKSchott
FredKSchott reviewed Dec 14, 2021
View reviewed changes
packages/astro/astro.js
@@ -46,7 +46,7 @@ async function main() {
// it's okay to hard-code the valid Node versions here since they will not change over time.
if (typeof require === 'undefined') {
console.error(`\nNode.js v${version} is not supported by Astro!
Please upgrade to a version of Node.js with complete ESM support: "^12.20.0 || ^14.13.1 || >=16.0.0"\n`);
Please upgrade to a version of Node.js with complete ESM support: "^14.15.0 || >=16.0.0"\n`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required in this PR, but we may now be able to remove supports-esm and most of the logic in this file and just check that process.versions.node > '14.15' instead of each ESM feature individually.

The context is that most of these checks were needed because Node v12 changed from version-to-version, and Node v14 was still actively supported and undergoing changes from version-to-version. Now it should be safe to do the more general > '14.15' check and leave it at that.

@jonathantneal jonathantneal merged commit 45cea6a into main Dec 16, 2021
@jonathantneal jonathantneal deleted the jn.use-node-14 branch December 16, 2021 23:53
@github-actions github-actions bot mentioned this pull request Dec 17, 2021
Merged
vineryap pushed a commit to vineryap/astro that referenced this pull request Dec 22, 2021
@jonathantneal @natemoo-re @vineryap
Support Node v14.15+ (withastro#2202)
241ad24 
* Support Node v14.15+

* changeset

* Update .changeset/new-hats-design.md

Co-authored-by: Nate Moore <[email protected]>

* Update .changeset/new-hats-design.md

Co-authored-by: Nate Moore <[email protected]>

* Update .changeset/new-hats-design.md

Co-authored-by: Nate Moore <[email protected]>

* ES2020

* update yarn.lock

Co-authored-by: Nate Moore <[email protected]>
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@jonathantneal @natemoo-re
Support Node v14.15+ (withastro#2202)
ac4b6f9 
* Support Node v14.15+

* changeset

* Update .changeset/new-hats-design.md

Co-authored-by: Nate Moore <[email protected]>

* Update .changeset/new-hats-design.md

Co-authored-by: Nate Moore <[email protected]>

* Update .changeset/new-hats-design.md

Co-authored-by: Nate Moore <[email protected]>

* ES2020

* update yarn.lock

Co-authored-by: Nate Moore <[email protected]>
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@jonathantneal @natemoo-re
Support Node v14.15+ (withastro#2202)
f795545 
* Support Node v14.15+

* changeset

* Update .changeset/new-hats-design.md

Co-authored-by: Nate Moore <[email protected]>

* Update .changeset/new-hats-design.md

Co-authored-by: Nate Moore <[email protected]>

* Update .changeset/new-hats-design.md

Co-authored-by: Nate Moore <[email protected]>

* ES2020

* update yarn.lock

Co-authored-by: Nate Moore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredKSchott FredKSchott FredKSchott approved these changes

@natemoo-re natemoo-re natemoo-re approved these changes

@matthewp matthewp Awaiting requested review from matthewp

Assignees
No one assigned
Labels
🚨 action Modifies GitHub Actions feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathantneal @FredKSchott @natemoo-re