Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing tests on main #2694

Merged
merged 1 commit into from
Mar 1, 2022
Merged

fix failing tests on main #2694

merged 1 commit into from
Mar 1, 2022

Conversation

FredKSchott
Copy link
Member

@FredKSchott FredKSchott commented Mar 1, 2022

  • In my CI work last night I accidentally merged a bad lockfile change that caused our tests to fail
  • Specifically, upgrading vite from .4 -> .5 caused a regression being tracked here: fix: upgraded vite #2678
  • This PR pins us to the last working version while the tests are fixed in fix: upgraded vite #2678

@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2022

⚠️ No Changeset found

Latest commit: 9e5d6e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 1, 2022
@FredKSchott FredKSchott changed the title fix failing tests on vite fix failing tests on main Mar 1, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FredKSchott FredKSchott mentioned this pull request Mar 1, 2022
@FredKSchott FredKSchott merged commit d9263c8 into main Mar 1, 2022
@FredKSchott FredKSchott deleted the fix-vite branch March 1, 2022 17:31
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants