Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix island deduplication ignoring props. #2825

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Fix island deduplication ignoring props. #2825

merged 3 commits into from
Mar 18, 2022

Commits on Mar 17, 2022

  1. Fix island deduplication ignoring props. 

    Re-resolves an issue initially patched in withastro#846 but seemingly lost in the 0.21.0 mega-merge (withastro@d84bfe7).
This change makes the component render step account for all props, even if they don't affect the generated HTML, when deduplicating island mount.
    @hlynursmari1
    hlynursmari1 committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    a45a3f1 View commit details
    Browse the repository at this point in the history

  2. Fix React component test using different rendered props to test dedup… 

    …lication.
    @hlynursmari1
    hlynursmari1 committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    99b046f View commit details
    Browse the repository at this point in the history

  3. fix: improve serialization support for non-JSON objects

    Nate Moore committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    63a1939 View commit details
    Browse the repository at this point in the history