Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix markdown page script injection #2871

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix markdown page script injection #2871

merged 1 commit into from
Mar 24, 2022

Conversation

FredKSchott
Copy link
Member

@FredKSchott FredKSchott commented Mar 24, 2022 •
edited
Loading

Changes

  • Markdown script injection was broken in a couple of small ways.
  • This PR hardens our script injection to use TS types better.
  • This PR also adds a Markdown example page to the with-tailwindcss example project
  • Last, we add a test to the test suite and make some small improvements to the tailwind test suite.

Testing

  • Manually confirmed and tests added.

Docs

  • N/A

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 3212cac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 24, 2022
@FredKSchott FredKSchott force-pushed the fix-markdown-page-tailwind branch 2 times, most recently from 9350127 to 49cd775 Compare March 24, 2022 00:40
@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Mar 24, 2022
@github-actions github-actions bot added the test label Mar 24, 2022
@FredKSchott FredKSchott force-pushed the fix-markdown-page-tailwind branch 2 times, most recently from ea2edad to 6ac78fb Compare March 24, 2022 16:24
@FredKSchott
Copy link
Member Author

FYI GH Actions are down but I believe tests are failing on a windows issue, will wait for them to come back up to debug

natemoo-re
natemoo-re approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean refactor and fix!

packages/astro/test/fixtures/tailwindcss/src/pages/index.astro Show resolved Hide resolved
packages/astro/test/tailwindcss.test.js Show resolved Hide resolved
@FredKSchott FredKSchott force-pushed the fix-markdown-page-tailwind branch 3 times, most recently from 382007b to 022c8cf Compare March 24, 2022 18:25
@FredKSchott FredKSchott merged commit 5029382 into main Mar 24, 2022
@FredKSchott FredKSchott deleted the fix-markdown-page-tailwind branch March 24, 2022 19:30
This was referenced Mar 24, 2022
Merged
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@FredKSchott
fix markdown page script injection (withastro#2871)
2df4860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @natemoo-re