Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes using React.lazy and Suspense #3160

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Fixes using React.lazy and Suspense #3160

merged 4 commits into from
Apr 21, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Test added for Suspense
  • Test added for Deno
  • Test added for Netlify

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2022

🦋 Changeset detected

Latest commit: b52fb6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@astrojs/deno Patch
@astrojs/netlify Patch
@astrojs/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) test labels Apr 20, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great test coverage 👏

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments but happy to approve if all looks good

@matthewp matthewp merged commit ae9ac5c into main Apr 21, 2022
@matthewp matthewp deleted the react-fixes branch April 21, 2022 16:10
@github-actions github-actions bot mentioned this pull request Apr 21, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Revert "Revert "Fixes using React.lazy and Suspense""

This reverts commit e621c2f.

* Adds a changeset

* Fix ts errors

* Remove netlify metadata folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: The server could not finish this Suspense boundary
3 participants