Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load environment variables in deno SSR #3483

Merged
merged 3 commits into from
May 31, 2022
Merged

Conversation

mvolfik
Copy link
Contributor

@mvolfik mvolfik commented May 31, 2022

Changes

Uses Deno.env to mock process.env

Testing

A test is added

Docs

One would expect this to work, but IMO doesn't need to be documented separately

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2022

🦋 Changeset detected

Latest commit: 03f656a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/deno Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label May 31, 2022
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, really great tests!

@matthewp matthewp merged commit b795a08 into withastro:main May 31, 2022
@github-actions github-actions bot mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants