Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tailwind integration Typescript warning #3732

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Fix Tailwind integration Typescript warning #3732

merged 3 commits into from
Jun 28, 2022

Conversation

inwardmovement
Copy link
Contributor

@inwardmovement inwardmovement commented Jun 27, 2022

Changes

Make Tailwind options optional to fix "An argument for 'options' was not provided."
Fixes #3716

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2022

🦋 Changeset detected

Latest commit: a073aec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/tailwind Patch
@e2e/e2e-tailwindcss Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 27, 2022
@inwardmovement
Copy link
Contributor Author

Can I let someone handle the changeset part? I run npx changeset but got
npm ERR! could not determine executable to run.

@natemoo-re
Copy link
Member

@inwardmovement Try pnpx changeset instead?

@inwardmovement
Copy link
Contributor Author

inwardmovement commented Jun 27, 2022

@natemoo-re 😑

> pnpx changeset
pnpx: The term 'pnpx' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
> npx changeset 
npx: installed 3 in 2.709s
command not found: changeset

I'm new to changesets, there may be something I'm not doing well

@tony-sull
Copy link
Contributor

@inwardmovement Thanks for opening the PR, and welcome to the growing list of Astro contributors!

I just added a changeset to the PR 👍 Looks like you opened the PR right from GitHub's edit link, changesets can be a little annoying there since you still end up having to sync down the branch anyway 🙃

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks for the assist @tony-sull!

@natemoo-re natemoo-re merged commit 6360f47 into withastro:main Jun 28, 2022
@astrobot-houston astrobot-houston mentioned this pull request Jun 28, 2022
@inwardmovement inwardmovement deleted the patch-1 branch July 1, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Tailwind integration throws "An argument for 'options' was not provided."
3 participants