Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double-escaping of non-highlighted code blocks in Astro-flavored Md #4169

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Fix double-escaping of non-highlighted code blocks in Astro-flavored Md #4169

merged 2 commits into from
Aug 5, 2022

Conversation

hippotastic
Copy link
Contributor

Changes

  • Fixes an edge case that caused HTML entities inside Astro-flavored Markdown code blocks to be escaped twice when syntax highlighting was disabled.

Testing

  • Added a test to verify expected behavior in the current Astro version.
  • Verified by adding this change to Astro Docs that it also doesn't break anything in older Astro versions.
  • Replaced incorrectly named test helper function renderAstroMd that actually rendered non-Astro-flavored Md.

Docs

  • Not a visible change, just a bugfix.

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 09288b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/markdown-remark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the feat: markdown Related to Markdown (scope) label Aug 5, 2022
@hippotastic hippotastic merged commit 16034f0 into withastro:main Aug 5, 2022
@hippotastic hippotastic deleted the hippotastic/pretty-alligator branch August 5, 2022 14:23
@astrobot-houston astrobot-houston mentioned this pull request Aug 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
feat: markdown Related to Markdown (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hippotastic @matthewp