Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite ignore unknown import #4527

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Vite ignore unknown import #4527

merged 2 commits into from
Aug 30, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 29, 2022

Changes

Small change to /* vite-ignore */ an unknown import as Vite warns about it since 3.0.9. This doesn't happen for the users, but only when they link Astro locally, which makes Astro ssr.noExternal by default.

Didn't add a changeset as it affects internal only.

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2022

🦋 Changeset detected

Latest commit: 36fd959

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@astrojs/react Patch
@e2e/error-react-spectrum Patch
@e2e/errors Patch
@e2e/react-component Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) labels Aug 29, 2022
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make this a patch to the React integration just to be safe. But looks like a small-but-ignoremous help 👍

@bluwy
Copy link
Member Author

bluwy commented Aug 29, 2022

Done!

@bluwy bluwy merged commit 9adb7cc into main Aug 30, 2022
@bluwy bluwy deleted the ignore-unknown-import branch August 30, 2022 07:25
@astrobot-houston astrobot-houston mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants