-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update peer dep with Tailwindcss #4543
Update peer dep with Tailwindcss #4543
Conversation
🦋 Changeset detectedLatest commit: 141d720 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Is this a breaking change? I think so. It might not be since tailwind is still a dependency, but in that case this change isn't actually doing anything. It makes more sense to remove Is this going to unexpectedly break users? It won't as long as we correctly changeset it as a major bump, with good information in the changelog. But it's definitely a big change and we should talk about timing before merging this PR. |
Update: `@astrojs/tailwindcss` project with `tailwindcss` as a `peer-dependency`
Thanks @FredKSchott, I made the amendment, in respects to the second question I would defer to your wisdom on this one. |
Co-authored-by: Bjorn Lu <[email protected]>
What's the status of this one @aFuzzyBear, is it ready to go? |
pretty much yes I believe, @bluwy did sign off on it, wasn't sure if there was anything else needed to be done, I'm hesitatent to merge this myself, unless given the okay, |
Changes
updated
package.json
withtailwindcss
as a peer dependency of the integration itself.Unsure if
changeset
is neededTesting
N/A
Docs
N/A