Improve cyclic reference detection, now ignores non-cyclic shared references

[natemoo-re]

Changes

• Issue reported on Discord
• Fixes our cyclic reference detection! A regression was introduced where valid shared references would throw, but this code makes it so non-cyclic but shared references are passed through properly.

Testing

Unit tests added!

Docs

N/A, bug fix only

[changeset-bot]

🦋 Changeset detected

Latest commit: cd932a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
astro	Patch
@e2e/astro-component	Patch
@e2e/error-cyclic	Patch
@e2e/error-react-spectrum	Patch
@e2e/error-sass	Patch
@e2e/errors	Patch
@e2e/hydration-race	Patch
@e2e/lit-component	Patch
@e2e/preact-component	Patch
@e2e/react-component	Patch
@e2e/solid-component	Patch
@e2e/solid-recurse	Patch
@e2e/svelte-component	Patch
@e2e/e2e-tailwindcss	Patch
@e2e/ts-resolution	Patch
@e2e/third-party-astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[matthewp]

love the new tests

[aFuzzyBear]

was just taking a look, couple of things I didnt understand, but now I know more about cyclic dependencies, the unit test really helped to make sense of it,