adjusting cloudflare adapter and solid ssr to work together

[AirBorne04]

Changes

• cloudflare adapter does now respect user config for ssr
• solid integration is now better configured for ssr so that it works with the adapter adjustments

Testing

• local testing with this repo

Docs

• adjusting some settings to make the integration work together as would be expected

[changeset-bot]

🦋 Changeset detected

Latest commit: f161c5d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[matthewp]

If this only fixes bugs then this shouldn't be a major. Maybe you were just being conservation here, or can you tell me what this breaks?

If this is a true breaking change I think we should have more explanation of the change in the changeset.

[AirBorne04]

adjusted this one to minor

[matthewp]

Still discussing this change so let's not merge yet. I think there's a solution here that will work, but one thing we probably need to do (especially if this is a major) is expose esbuild options as config.

[AirBorne04]

I think there's a solution here that will work, but one thing we probably need to do (especially if this is a major) is expose esbuild options as config.

There is not really a need to expose the esbuild options as config i think, unless there is lib that needs to import the node config from a package (and you are running with react) but you could also precompile than manually.

the logic this adapter now follows is

• build the framework for the ssr target (solid uses node, react uses browser)
• bundle the rest of the libs used with esbuild for the platform browser

especially if this is a major
from my point of view it does not need to be a major

• the solid integration it is just fixing something that was anyway broken
• the cloudflare adapter is actually changing the import, but does fix a bug (but might break something on other integrations like vue, preact ...)

Is there a minimal repo for the other frameworks (svelte, preact, react, vue, lit) to check againts. I am willing to run through them and check if they generally work with this config in ssr mode, or if there is a fix needed for any of them, to get this working more stable?

[matthewp]

@AirBorne04 there is the framework-* in the examples/ folder. Can you test against this?

I understand the trepidation about adding too much config. If you want to check out the other frameworks and let me know, I'd be happy to proceed with the current changes.

The only other thing I would ask for is a lengthier (paragraph or two) explanation of the changes in the changeset.

[AirBorne04]

hi,

i finally got to do the work. Nearly all example projects are running fine, only lit is not working out of the box. The issue here is that the frameworks ssr package heavily relies on node functionality. This is currently discussed in an issue here #4999 and therefore i think it is out of scope getting it to work, before the core team has enabled this functionality.

[matthewp]

Thanks @AirBorne04, I agree, the issue here wasn't to try and get every framework to work with Cloudflare. Just making sure this solution didn't break the ones that people were already using, and it sounds like you achieved that. Thank you!

[matthewp]

• Closes Error while building using cloudflare adapter #4869
• Closes Cannot build with Vue framework and Cloudflare adapter #4949
• Closes Crash during build with Sanity and Cloudflare adapter #4951
• Closes 🐛 BUG: SolidJs and cloudflare workers doesnt work #4039