Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image external config in build #5073

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Fix image external config in build #5073

merged 1 commit into from
Oct 13, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 13, 2022

Changes

Fix regression from #5034

That PR fixes dev but breaks build for strict dependency installation. This removes the changes in #5034 for build only.

Testing

Tested while working on #4925. Similar to #5034 it's tricky to create a test for this.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2022

🦋 Changeset detected

Latest commit: f5c910b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 13, 2022
@matthewp matthewp merged commit 93f72f9 into main Oct 13, 2022
@matthewp matthewp deleted the fix-image-external branch October 13, 2022 15:16
@astrobot-houston astrobot-houston mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants