Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shamefully-hoist from docs smoke test #5193

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Remove shamefully-hoist from docs smoke test #5193

merged 2 commits into from
Oct 31, 2022

Conversation

mrienstra
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 31d4865

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Oct 25, 2022
@bluwy
Copy link
Member

bluwy commented Oct 26, 2022

Looks like it'd be better to not rely on the .npmrc hoisting that's still in the astro-docs repo. I'll tweak that a bit and this should work then.

@bluwy bluwy mentioned this pull request Oct 26, 2022
Merged
@mrienstra
Copy link
Contributor Author

@bluwy, looks like this is good to go, thanks to withastro/docs#1925.

bluwy
bluwy approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@bluwy bluwy merged commit 0e043bb into withastro:main Oct 31, 2022
@mrienstra mrienstra deleted the patch-4 branch October 31, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrienstra @bluwy