Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temp tailwind config file in finally #5450

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

chenxsan
Copy link
Contributor

Changes

Closes #5439

Testing

Tested in local project.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2022

🦋 Changeset detected

Latest commit: 8be6f9d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Nov 21, 2022
@@ -47,10 +47,10 @@ async function getUserConfig(root: URL, configPath?: string, isRestart = false)
cwd: resolvedRoot,
filePath: tempConfigPath,
});

} catch (err) {
console.error(err)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found myself checking the terminal more often than the editor for errors, so would like to print the error here.

Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matthewp matthewp merged commit cef33dd into withastro:main Nov 21, 2022
@astrobot-houston astrobot-houston mentioned this pull request Nov 21, 2022
@chenxsan chenxsan deleted the bugfix/remove-temp-file branch November 22, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

temp tailwind.config.js file not removed.
2 participants