Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy.astroFlavoredMarkdown #5771

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jan 5, 2023

Changes

  • Removes all code related to legacy.astroFlavoredMarkdown
  • Keeps the legacy config object for possible future use.

Testing

  • All tests updated or removed.

Docs

  • Yes, astro types updated to remove the option.

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2023

🦋 Changeset detected

Latest commit: a920503

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) feat: markdown Related to Markdown (scope) labels Jan 5, 2023
@matthewp matthewp marked this pull request as ready for review January 5, 2023 18:33
@matthewp matthewp requested a review from a team as a code owner January 5, 2023 18:33
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs will handle wiping links to AFMD legacy config from the rest of Docs site.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP. LGTM.

@FredKSchott
Copy link
Member

Screen Shot 2023-01-05 at 12 16 33 PM

Goodnight, sweet prince.

@FredKSchott
Copy link
Member

Don't forget a changeset! Important to mark that this has happened for the migration guide.

@natemoo-re
Copy link
Member

Goodnight, sweet ASTRO_ESCAPED_LEFT_CURLY_BRACE.

@matthewp matthewp merged commit 259a539 into main Jan 5, 2023
@matthewp matthewp deleted the remove-astro-flavored-markdown branch January 5, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants