Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[markdown-remark] Remove unused dependencies #5804

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Conversation

delucis
Copy link
Member

@delucis delucis commented Jan 9, 2023

Changes

Follow up to #5785. I missed that acorn and hast-util-to-html are no longer used by @astrojs/markdown-remark and can be removed as dependencies.

Does this need a patch changeset separate to #5785 or is it minimal enough to ignore?

Testing

Existing tests should pass.

Docs

No docs needed.

Follow up to #5785. Missed one dependency that is no longer used and can be removed.
@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2023

⚠️ No Changeset found

Latest commit: 5c5adfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the feat: markdown Related to Markdown (scope) label Jan 9, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like the lockfile needs another update before merging

@delucis
Copy link
Member Author

delucis commented Jan 9, 2023

Hmm, merging seems to have cause a lot more changes in the lockfile vs main. Maybe a bad merge? Yeah, looks like this is undoing lots of the most recent update lockfile CI.

@delucis
Copy link
Member Author

delucis commented Jan 9, 2023

I tried removing the lock file and running pnpm install --lockfile-only like the lockfile CI task does but that doesn’t seem to produce any changes. Not sure what the simple way to resolve this is. Maybe it doesn’t matter?

@bluwy
Copy link
Member

bluwy commented Jan 9, 2023

Looking into the lockfile, it seems to be reverting the changes of the recent lockfile update. I usually do a merge, and during conflicts, run pnpm i as pnpm supports ootb conflict resolve. Maybe it's worth resetting the branch to main, remove the remark deps, and run pnpm i again to fix it 🤔

@delucis
Copy link
Member Author

delucis commented Jan 9, 2023

This was a good tip. Checked out main, ran pnpm i, checked out my branch, removed the lockfile, ran pnpm i again and it generated the expected lockfile 👍

I actually didn’t see any conflicts while merging, maybe because I have pnpm-merge-driver configured as suggested in CONTRIBUTING.md? Anyway, should be good now!

@bluwy
Copy link
Member

bluwy commented Jan 9, 2023

Yeah I never quite understood why pnpm-merge-driver was recommended 😅 Glad that's fixed now. PR looks good to me!

@delucis delucis merged commit f354114 into main Jan 9, 2023
@delucis delucis deleted the chris/5785-followup branch January 9, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants