Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle server restart from Vite plugins #5849

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Handle server restart from Vite plugins #5849

merged 1 commit into from
Jan 14, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 13, 2023

Changes

Fix #5783

Override Vite's server.restart API with our implementation.

Testing

Added a unit test, and manually tested the repro that it works.

Docs

n/a. bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2023

🦋 Changeset detected

Latest commit: 484ea34

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 13, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever, this is exciting!

@bluwy bluwy merged commit 8c100a6 into main Jan 14, 2023
@bluwy bluwy deleted the plugin-restart branch January 14, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR not working when triggered from vite plugin
2 participants