Remove duplicate CSS in dev #5917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 07bc93a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
github-actions
bot
added
the
pkg: astro
1 task
matthewp
reviewed
Jan 23, 2023
| @@ -133,7 +133,11 @@ async function getScriptsAndStyles({ env, filePath }: GetScriptsAndStylesParams) | |||
| }); | |||
| // But we still want to inject the styles to avoid FOUC | |||
| styles.add({ | |||
| props: {}, | |||
| props: { | |||
| type: 'text/css', | |||
There was a problem hiding this comment.
is this because vite needs the attributes to match? if not, type is not need on script or style, <style> is always text/css.
There was a problem hiding this comment.
No, data-astro-dev-id is the only necessary change here. I just added this for consistency with the styles Vite injects.
matthewp
approved these changes
Jan 23, 2023
Merged
matthewp
pushed a commit
that referenced
this pull request
Jan 26, 2023
* fix(#5817): remove duplicate CSS in dev * chore: add changeset Co-authored-by: Nate Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
vite.css.devSourcemapis enabledDocs
Bug fix only