Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the AstroCookies type importable directly from "astro" #6006

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

tony-sull
Copy link
Contributor

Changes

This re-exports the AstroCookies type from the main @types/astro.ts type definitions.

Current import syntax

import type { AstroCookies } from "astro/dist/core/cookies/cookies.js"

New import

import type { AstroCookies } from "astro"

Testing

Tested locally

Docs

None, typescript fix only

@tony-sull tony-sull requested a review from a team as a code owner January 27, 2023 15:52
@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2023

🦋 Changeset detected

Latest commit: 8fc8d7e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 27, 2023
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@tony-sull tony-sull merged commit b994f6f into main Jan 27, 2023
@tony-sull tony-sull deleted the fix/export-cookies-type branch January 27, 2023 17:00
This was referenced Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants