feat(cli): add `--watch` to `astro check` command #6356

ematipico · 2023-02-24T11:59:05Z

Changes

See withastro/roadmap#473 for more context.

This PR adds a new argument to the command astro check called --watch.

Coding-wise, I refactored the file, but the command's core logic is the same.

This PR takes advantage of the watcher provided by vite. vite uses chokidar as a file watcher. When a file is added/modified, we upsert the document and run the checker. When a file is deleted - unlink - we remove and rerun the checker.

I had to change the part where we created the vite configuration. Passing watch.ignore: undefined was breaking the watcher.

Testing

I added a new test case to make sure we receive an error if we modify a file that was previously valid.

I also tested the feature manually, locally.

Docs

Requires documentation

changeset-bot · 2023-02-24T11:59:09Z

🦋 Changeset detected

Latest commit: ba8c3b8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ematipico · 2023-02-27T14:39:47Z

!preview check-watch

github-actions · 2023-02-27T14:45:07Z

 > [email protected] release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--check-watch" > [email protected] build /home/runner/work/astro/astro > turbo run build --output-logs=new-only --no-deps --filter=astro --filter=create-astro --filter="@astrojs/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/image, @astrojs/lit, @astrojs/markdown-component, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/turbolinks, @astrojs/vercel, @astrojs/vue, @astrojs/webapi, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote computation caching enabled (experimental)�[0m �[35m@astrojs/webapi:build: �[0mcache miss, executing �[2m3c99032d1c1cb943�[0m �[35m@astrojs/webapi:build: �[0m �[35m@astrojs/webapi:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/webapi �[35m@astrojs/webapi:build: �[0m> node run/build.js �[35m@astrojs/webapi:build: �[0m �[34mcreate-astro:build: �[0mcache miss, executing �[2m58cb0432b633bd0f�[0m �[33m@astrojs/telemetry:build: �[0mcache miss, executing �[2m1336aa342ff9b7d3�[0m �[36m@astrojs/prism:build: �[0mcache miss, executing �[2m6a01aa5c027fc60e�[0m �[34mcreate-astro:build: �[0m �[34mcreate-astro:build: �[0m> [email protected] build /home/runner/work/astro/astro/packages/create-astro �[34mcreate-astro:build: �[0m> astro-scripts build "src/index.ts" --bundle && tsc �[34mcreate-astro:build: �[0m �[33m@astrojs/telemetry:build: �[0m �[33m@astrojs/telemetry:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/telemetry �[33m@astrojs/telemetry:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/telemetry:build: �[0m �[36m@astrojs/prism:build: �[0m �[36m@astrojs/prism:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/astro-prism �[36m@astrojs/prism:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/prism:build: �[0m �[35m@astrojs/markdown-remark:build: �[0mcache miss, executing �[2medb18106052d816d�[0m �[35m@astrojs/markdown-remark:build: �[0m �[35m@astrojs/markdown-remark:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/markdown/remark �[35m@astrojs/markdown-remark:build: �[0m> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json �[35m@astrojs/markdown-remark:build: �[0m �[32mastro:build: �[0mcache miss, executing �[2md37a931233293ea5�[0m �[32mastro:build: �[0m �[32mastro:build: �[0m> [email protected] build /home/runner/work/astro/astro/packages/astro �[32mastro:build: �[0m> pnpm run prebuild && astro-scripts build "src/**/*.ts" && tsc �[32mastro:build: �[0m �[32mastro:build: �[0m �[32mastro:build: �[0m> [email protected] prebuild /home/runner/work/astro/astro/packages/astro �[32mastro:build: �[0m> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" �[32mastro:build: �[0m �[32m@astrojs/vercel:build: �[0mcache miss, executing �[2m55c82ffc46918b33�[0m �[35m@astrojs/lit:build: �[0mcache miss, executing �[2m8702a7c804bb6097�[0m �[34m@astrojs/mdx:build: �[0mcache miss, executing �[2m18674f784e48fceb�[0m �[35m@astrojs/preact:build: �[0mcache miss, executing �[2m550df9c18e4359d1�[0m �[34m@astrojs/turbolinks:build: �[0mcache miss, executing �[2m111409b7f3ef7ea6�[0m �[33m@astrojs/node:build: �[0mcache miss, executing �[2m2a6d7d96272a7589�[0m �[32m@astrojs/vue:build: �[0mcache miss, executing �[2m45031d1f0141782b�[0m �[36m@astrojs/netlify:build: �[0mcache miss, executing �[2m27af1cf4a0ddccb1�[0m �[36m@astrojs/prefetch:build: �[0mcache miss, executing �[2mfc8121e7d4ef0bd8�[0m �[33m@astrojs/solid-js:build: �[0mcache miss, executing �[2m7f071de1ef9a35cd�[0m �[35m@astrojs/lit:build: �[0m �[35m@astrojs/lit:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/lit �[35m@astrojs/lit:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/lit:build: �[0m �[33m@astrojs/node:build: �[0m �[33m@astrojs/node:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/node �[33m@astrojs/node:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/node:build: �[0m �[34m@astrojs/mdx:build: �[0m �[34m@astrojs/mdx:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/mdx �[34m@astrojs/mdx:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/mdx:build: �[0m �[32m@astrojs/vercel:build: �[0m �[32m@astrojs/vercel:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/vercel �[32m@astrojs/vercel:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/vercel:build: �[0m �[36m@astrojs/prefetch:build: �[0m �[36m@astrojs/prefetch:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/prefetch �[36m@astrojs/prefetch:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/prefetch:build: �[0m �[35m@astrojs/preact:build: �[0m �[35m@astrojs/preact:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/preact �[35m@astrojs/preact:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/preact:build: �[0m �[32m@astrojs/vue:build: �[0m �[32m@astrojs/vue:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/vue �[32m@astrojs/vue:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[32m@astrojs/vue:build: �[0m �[36m@astrojs/netlify:build: �[0m �[36m@astrojs/netlify:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/netlify �[36m@astrojs/netlify:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/netlify:build: �[0m �[34m@astrojs/turbolinks:build: �[0m �[34m@astrojs/turbolinks:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/turbolinks �[34m@astrojs/turbolinks:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/turbolinks:build: �[0m �[33m@astrojs/solid-js:build: �[0m �[33m@astrojs/solid-js:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/solid �[33m@astrojs/solid-js:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/solid-js:build: �[0m �[33m@astrojs/alpinejs:build: �[0mcache miss, executing �[2mda0c9858eb3109aa�[0m �[34m@astrojs/tailwind:build: �[0mcache miss, executing �[2md495e61f25df5f6f�[0m �[36m@astrojs/react:build: �[0mcache miss, executing �[2m13bbca27cfb608fe�[0m �[35m@astrojs/svelte:build: �[0mcache miss, executing �[2mf7dac10c7c2ac655�[0m �[33m@astrojs/alpinejs:build: �[0m �[33m@astrojs/alpinejs:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/alpinejs �[33m@astrojs/alpinejs:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/alpinejs:build: �[0m �[32m@astrojs/rss:build: �[0mcache miss, executing �[2m1f7e8f29e9846e15�[0m �[34m@astrojs/partytown:build: �[0mcache miss, executing �[2mb03850003c336a78�[0m �[35m@astrojs/cloudflare:build: �[0mcache miss, executing �[2md0de98c3519d5b18�[0m �[34m@astrojs/tailwind:build: �[0m �[34m@astrojs/tailwind:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/tailwind �[34m@astrojs/tailwind:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/tailwind:build: �[0m �[36m@astrojs/deno:build: �[0mcache miss, executing �[2me8eace1da2ea71a4�[0m �[36m@astrojs/react:build: �[0m �[36m@astrojs/react:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/react �[36m@astrojs/react:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/react:build: �[0m �[32m@astrojs/image:build: �[0mcache miss, executing �[2m1640f726b7675760�[0m �[35m@astrojs/svelte:build: �[0m �[35m@astrojs/svelte:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/svelte �[35m@astrojs/svelte:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[35m@astrojs/svelte:build: �[0m �[33m@astrojs/sitemap:build: �[0mcache miss, executing �[2m5da89f389e977976�[0m �[32m@astrojs/rss:build: �[0m �[32m@astrojs/rss:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/astro-rss �[32m@astrojs/rss:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/rss:build: �[0m �[35m@astrojs/cloudflare:build: �[0m �[35m@astrojs/cloudflare:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/cloudflare �[35m@astrojs/cloudflare:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/cloudflare:build: �[0m �[34m@astrojs/partytown:build: �[0m �[34m@astrojs/partytown:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/partytown �[34m@astrojs/partytown:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/partytown:build: �[0m �[36m@astrojs/deno:build: �[0m �[36m@astrojs/deno:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/deno �[36m@astrojs/deno:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/deno:build: �[0m �[32m@astrojs/image:build: �[0m �[32m@astrojs/image:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/image �[32m@astrojs/image:build: �[0m> astro-scripts build "src/**/*.ts" && tsc && pnpm run postbuild �[32m@astrojs/image:build: �[0m �[33m@astrojs/sitemap:build: �[0m �[33m@astrojs/sitemap:build: �[0m> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/sitemap �[33m@astrojs/sitemap:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/sitemap:build: �[0m �[32m@astrojs/image:build: �[0m �[32m@astrojs/image:build: �[0m> @astrojs/[email protected] postbuild /home/runner/work/astro/astro/packages/integrations/image �[32m@astrojs/image:build: �[0m> astro-scripts copy "src/**/*.wasm" �[32m@astrojs/image:build: �[0m Tasks: 26 successful, 26 total Cached: 0 cached, 26 total Time: 1m43.287s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--check-watch tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/image 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/turbolinks 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/markdown-component 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/webapi 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-check-watch-20230227144241) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 2.1.1 is already published on npm 🦋 �[36minfo�[39m create-astro is being published because our local version (0.0.0-check-watch-20230227144241) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.1.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/cloudflare is not being published because version 6.1.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 4.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/image is not being published because version 0.15.1 is already published on npm 🦋 �[36minfo�[39m @astrojs/lit is being published because our local version (0.0.0-check-watch-20230227144241) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 0.17.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 2.1.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 5.0.4 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 1.0.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 2.0.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 1.1.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/turbolinks is not being published because version 0.1.5 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 3.1.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-component is not being published because version 1.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 2.0.1 is already published on npm 🦋 �[36minfo�[39m @astrojs/telemetry is being published because our local version (0.0.0-check-watch-20230227144241) has not been published on npm 🦋 �[36minfo�[39m @astrojs/webapi is being published because our local version (0.0.0-check-watch-20230227144241) has not been published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-check-watch-20230227144241"�[39m 🦋 �[36minfo�[39m Publishing �[36m"create-astro"�[39m at �[32m"0.0.0-check-watch-20230227144241"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/lit"�[39m at �[32m"0.0.0-check-watch-20230227144241"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/telemetry"�[39m at �[32m"0.0.0-check-watch-20230227144241"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/webapi"�[39m at �[32m"0.0.0-check-watch-20230227144241"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 [email protected] 🦋 [email protected] 🦋 @astrojs/[email protected] 🦋 @astrojs/[email protected] 🦋 @astrojs/[email protected] 🦋 Creating git tags... 🦋 New tag: [email protected] 🦋 New tag: [email protected] 🦋 New tag: @astrojs/[email protected] 🦋 New tag: @astrojs/[email protected] 🦋 New tag: @astrojs/[email protected]

github-actions

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

github-actions

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

packages/astro/test/cli.test.js

matthewp · 2023-02-28T16:40:21Z

packages/astro/test/fixtures/astro-check-watch/tsconfig.json

@@ -0,0 +1,2 @@
+// Having a `tsconfig.json`, even empty speeds up the test massively since TypeScript does not have to look for one


good comment to add

packages/astro/test/test-utils.js

matthewp · 2023-02-28T16:41:55Z

Looks really good overall! Just left a few comments.

github-actions

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

packages/astro/src/cli/check/index.ts

packages/astro/src/core/build/index.ts

packages/astro/test/test-utils.js

packages/webapi/mod.d.ts

packages/astro/src/cli/check/index.ts

bluwy

Awesome. Thanks for making the changes 💚 Looking forward for this to land!

Today is merge day

Co-authored-by: Erika <[email protected]>

commit fbab73c Author: matthewp <[email protected]> Date: Tue Mar 7 16:38:11 2023 +0000 [ci] format commit a206106 Author: Matthew Phillips <[email protected]> Date: Tue Mar 7 11:35:54 2023 -0500 Expose the ssr manifest (#6435) * Expose the ssr manifest * Add changeset * Add types for virtual mod commit 2751584 Author: Princesseuh <[email protected]> Date: Tue Mar 7 15:14:15 2023 +0000 [ci] format commit 694918a Author: Erika <[email protected]> Date: Tue Mar 7 16:12:21 2023 +0100 Implement RFC "A core story for images" (#6344) * feat(assets): Add Vite plugin * feat(images): Set up Image component * fix(types): Attempt to fix type generation * Revert "fix(types): Attempt to fix type generation" This reverts commit 063aa27. * fix(image): Fix image types causing build to fail * feat(image): Implement client side part * feat(services): Allow arbitrary transforms parameters * fix(image): Fix paths and types * config(types): Update config types to provide completions for available services * feat(image): Add serving in dev * feat(image): Improve type error messages * refactor(image): Move sharp's parseParams to baseService * refactor(image): Skip work in dev for remote servies * feat(image): Add support for remote images * feat(image): Add squoosh service * chore: update export map * refactor(image): Abstract attributes handling by services * config(vercel): Remove test image service * feat(image): Support for relative images in Markdown (WIP) * feat(images): Add support for relative images in Markdown * feat(image): Update with RFC feedback * fix(image): Fix alt error on getImage * feat(image): Add support for assets validation through content collections * feat(image): Remove validateTransform * feat(image): Move to assets folder * fix(image): Fix package exports * feat(image): Add static imports references to virtual moduel * fix(image): Fix images from content collections not working when embedded * chore: lockfile * fix(markdown): Fix type * fix(images): Flag enhanced images behing an experimental flag * config(example): Update images example conifg * fix(image): Fix types * fix(image): Fix asset type for strict, allow arbritary input and output formats * chore: fix example check * feat(image): Emit assets for ESM imported images * Add initial core image tests (#6381) * feat(images): Make frontmatter extraction more generic than images for future * feat(image): Add support for building * fix(image): Fix types * fix(images): Fix compatibility with image integration * feat(images): Cuter generation stats * fix(images): Globals are unsafe, it turns out * fix(images): Only generate images if flag is enabled * fix(images): Only create `addStaticImage` in build * feat(images): Add SSR endpoint * fix(images): Only inject route in SSR * Add tests for SSR * Remove console.log * Updated lockfile * rename to satisfy the link gods * skip build tests for now * fix(images): Fix WASM files not being copied in dev * feat(images): Add quality presets * fix build tests running * Remove console.log * Add tests for getImage * Test local services * Test the content collections API * Add tests for quality * Skipping content collections test * feat(image): Add support for `~/assets` alias * test(image): Add tests for aliases in dev * Fix windows + content collections * test(image): Add tests for aliased images and images in Markdown * Fix markdown images being built * Should be posix join * Use the optimized image * fix test * Fixes windows smoke * fix(image): Nits * feat(images): Add automatic update for `env.d.ts` when experimental images are enabled * fix(images): Revert env.d.ts change if the user opted-out of the experimental image support * chore: remove bad image example project * feat(image): Rename `experimental.images` to `experimental.assets` * fix(images): Remove unused code in MDX integration * chore: Remove unrelated change * fix(images): Remove export from astro/components * Fix, esm import on Win * test(images): Add test for format * fix(images): Add `client-image.d.ts` to export map * chore: changeset * fix(images): Adjust with feedback, no more automatic refine, asset() -> image() * fix(images): Fix types * fix(images): Remove unnecessary spread * fix(images): Better types for parseUrl and transform * fix(images): Fix types * fix(images): Adjust from feedback * fix(images): Pass width and height through getHTMLAttributes even if they're not added by the uesr * fix(images): Recusirsively extract frontmatter assets * fix(images): Use a reduce instead * feat(images): Add support for data: URIs * chore: changeset * docs(images): Misc docs fixes * Update .changeset/gold-rocks-cry.md Co-authored-by: Chris Swithinbank <[email protected]> * Update .changeset/gold-rocks-cry.md Co-authored-by: Sarah Rainsberger <[email protected]> * Update packages/astro/src/@types/astro.ts Co-authored-by: Chris Swithinbank <[email protected]> * Update packages/astro/src/assets/services/service.ts Co-authored-by: Chris Swithinbank <[email protected]> * Update packages/astro/src/assets/services/service.ts Co-authored-by: Chris Swithinbank <[email protected]> * Update packages/astro/src/assets/services/service.ts Co-authored-by: Chris Swithinbank <[email protected]> * Update packages/astro/src/assets/types.ts Co-authored-by: Chris Swithinbank <[email protected]> * Update packages/astro/src/assets/types.ts Co-authored-by: Chris Swithinbank <[email protected]> --------- Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Chris Swithinbank <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]> commit 377530a Author: ematipico <[email protected]> Date: Tue Mar 7 13:43:21 2023 +0000 [ci] format commit fe88f89 Author: Emanuele Stoppa <[email protected]> Date: Tue Mar 7 13:41:24 2023 +0000 chore: use directive `@ts-expect-error` instead of `@ts-ignore` (#6429) commit e1858e6 Author: ematipico <[email protected]> Date: Tue Mar 7 06:57:52 2023 +0000 [ci] format commit 75921b3 Author: Emanuele Stoppa <[email protected]> Date: Tue Mar 7 06:55:41 2023 +0000 feat(cli): add `--watch` to `astro check` command (#6356) * feat(cli): add `--watch` to `astro check` command * chore: refactor in a leaner way, logic not changed * chore: lint * chore: revert changes in sync command * chore: tweak server settings * test: add one test case * chore: increase timeout * test: predictable testing * chore: add changeset * chore: code suggestions * code suggestions * chore: use directly `chokidar` * chore: tweak code * fix: open documents first * chore: disable test * chore: code suggestions * chore: code suggestions * Apply suggestions from code review Co-authored-by: Erika <[email protected]> * code suggestions * chore: rebase --------- Co-authored-by: Erika <[email protected]> commit 1291afc Author: Bjorn Lu <[email protected]> Date: Tue Mar 7 14:50:34 2023 +0800 Fix changeset run (#6442) commit 00a0af7 Author: Bjorn Lu <[email protected]> Date: Tue Mar 7 10:52:47 2023 +0800 Move benchmark package and update changeset config (#6433) commit af05a4f Author: Nate Moore <[email protected]> Date: Mon Mar 6 14:06:33 2023 -0600 Update README.md (#6437) * Update README.md * Update README.md commit 8ebf4b7 Author: Nate Moore <[email protected]> Date: Mon Mar 6 14:03:33 2023 -0600 chore: update branding assets (#6436) commit afbbc4d Author: Erika <[email protected]> Date: Mon Mar 6 19:57:16 2023 +0100 Update compilation target for Node 16 (#6213) * config(esbuild): Update esbuild target to node16 * config(package): Update root package.json node engine * config(tsconfig): Update all the tsconfigs module and targets * chore: changeset * chore: remove unneeded file commit 18acae3 Author: Sarah Rainsberger <[email protected]> Date: Mon Mar 6 14:36:40 2023 -0400 [error docs] update link for client-side scripts (#6423) commit 8b49d17 Author: ematipico <[email protected]> Date: Mon Mar 6 17:03:18 2023 +0000 [ci] format commit a4a74ab Author: Emanuele Stoppa <[email protected]> Date: Mon Mar 6 16:58:56 2023 +0000 feat(cli): add help flags to various commands (#6394) Co-authored-by: Happydev <[email protected]> commit b087b83 Author: Dennis Morello <[email protected]> Date: Mon Mar 6 17:38:42 2023 +0100 Add getStaticPaths type helpers to infer params and props (#6150) * feat(astro): add InferGetStaticParamsType and InferGetStaticPropsType type helpers * chore(astro): added changeset commit 19fe4cb Author: Houston (Bot) <[email protected]> Date: Mon Mar 6 08:30:38 2023 -0800 [ci] release (#6414) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: integration setup * feat: get markdoc contents * wip: expose Markdoc from integration * feat: basic Astro renderer in with-markdoc * fix: component render bug * deps: stringify-attributes * fix: render attributes to html * wip: play with separate markdoc config * wip: get dream API for file loader working * chore: unit tests * deps: graymatter * feat: addContentEntryType integration hook * deps: move to @astrojs/markdoc * feat: move Renderer to markdoc, get Content component! * wip: scaffold content types * deps: mdx * wip: move mdx to collection type API * refactor: move plain md to content entry type * refactor: pass file contents * oops, forgot to commit untracked * fix: markdoc.config loading * refactor: remove fallback loader * chore: remove unused dream file * deps: devalue, test fixture * test: entry and collections parse * play: make sure md also works * deps: add shiki for Code comp error * fix: remove "components" from tsconfig * chore: ignore `.astro` type error * fix: avoid import if no config present (prod build error) * fix: stop bundling markdoc for isTag * test: prod builds * test: content component dev and build * chore: Markdoc working! log * fix: ContentEntryType import * chore: remove content-types. Too early! * chore: remove unused options object * play: add docs example with Aside and Since ported * chore: with-markdoc strictNullChecks * chore: unused file * feat: allow Render type injection * feat: content prop types for markdoc! * chore: clean up Markdoc starter to essentials * chore: unused style tag * chore: remove unused deps * fix: glob for single content extension * chore: remove unused fixture dep * chore: remove markdoc.config loader * docs: update example README * docs: @astrojs/markdoc README intro * fix: line endings in test * docs: add usage and examples to Markdoc README * docs: change with-markdoc title * docs: README edits * refactor: clean up astroNode * nit: reorder type import * docs: add note on Aside src * chore: changeset * nit: 0.0.0 to avoid version bump * fix: lock * refactor: remove unneeded async * fix: import types from @astrojs/markdoc * fix: type inferencing in preview * fix: remove unneeded html-escaper * deps: remove html-escaper * feat: support `.md` overrides for content collections * chore: mdoc -> md * feat: generate `.md` types override * Revert "feat: support `.md` overrides for content collections" This reverts commit c06f83e. * Squashed commit of `markdoc-poc` commit bd0dd9d Author: bholmesdev <[email protected]> Date: Wed Feb 15 09:43:04 2023 -0500 Revert "feat: support `.md` overrides for content collections" This reverts commit c06f83e. commit 5b9a1f3 Author: bholmesdev <[email protected]> Date: Tue Feb 14 13:48:56 2023 -0500 feat: generate `.md` types override commit e464ae8 Author: bholmesdev <[email protected]> Date: Tue Feb 14 12:56:11 2023 -0500 chore: mdoc -> md commit b74fd6a Author: bholmesdev <[email protected]> Date: Tue Feb 14 12:56:01 2023 -0500 feat: support `.md` overrides for content collections commit bdcc18a Author: bholmesdev <[email protected]> Date: Tue Feb 14 12:30:48 2023 -0500 deps: remove html-escaper commit f44b57f Author: bholmesdev <[email protected]> Date: Tue Feb 14 12:30:42 2023 -0500 fix: remove unneeded html-escaper commit fb79194 Author: bholmesdev <[email protected]> Date: Tue Feb 14 12:08:04 2023 -0500 fix: type inferencing in preview commit 0c05034 Author: bholmesdev <[email protected]> Date: Tue Feb 14 11:32:19 2023 -0500 fix: import types from @astrojs/markdoc commit 57e741a Author: bholmesdev <[email protected]> Date: Tue Feb 14 11:28:33 2023 -0500 refactor: remove unneeded async commit b19d854 Author: bholmesdev <[email protected]> Date: Tue Feb 14 10:26:20 2023 -0500 fix: lock commit b1083a1 Author: bholmesdev <[email protected]> Date: Tue Feb 14 10:19:50 2023 -0500 nit: 0.0.0 to avoid version bump commit 71891eb Author: bholmesdev <[email protected]> Date: Tue Feb 14 09:33:27 2023 -0500 chore: changeset commit 444752a Author: bholmesdev <[email protected]> Date: Tue Feb 14 09:30:10 2023 -0500 docs: add note on Aside src commit 619d4b3 Author: bholmesdev <[email protected]> Date: Tue Feb 14 09:25:56 2023 -0500 nit: reorder type import commit e914da0 Author: bholmesdev <[email protected]> Date: Tue Feb 14 09:25:38 2023 -0500 refactor: clean up astroNode commit 2dfc226 Author: bholmesdev <[email protected]> Date: Tue Feb 14 09:08:56 2023 -0500 docs: README edits commit 3c7b85c Author: bholmesdev <[email protected]> Date: Tue Feb 14 09:07:29 2023 -0500 docs: change with-markdoc title commit 29cdea9 Author: bholmesdev <[email protected]> Date: Mon Feb 13 18:29:10 2023 -0500 docs: add usage and examples to Markdoc README commit e397a80 Author: bholmesdev <[email protected]> Date: Mon Feb 13 18:18:54 2023 -0500 fix: line endings in test commit f9ebf59 Author: bholmesdev <[email protected]> Date: Mon Feb 13 18:09:15 2023 -0500 docs: @astrojs/markdoc README intro commit 7800e9c Author: bholmesdev <[email protected]> Date: Mon Feb 13 18:08:07 2023 -0500 docs: update example README commit f0b900a Author: bholmesdev <[email protected]> Date: Mon Feb 13 18:04:34 2023 -0500 chore: remove markdoc.config loader commit 3f040e4 Author: bholmesdev <[email protected]> Date: Mon Feb 13 17:58:52 2023 -0500 chore: remove unused fixture dep commit b2ea6c2 Author: bholmesdev <[email protected]> Date: Mon Feb 13 17:58:25 2023 -0500 fix: glob for single content extension commit f4e171c Author: bholmesdev <[email protected]> Date: Mon Feb 13 15:10:39 2023 -0500 chore: remove unused deps commit d9095d0 Author: bholmesdev <[email protected]> Date: Mon Feb 13 15:10:31 2023 -0500 chore: unused style tag commit a5435f1 Author: bholmesdev <[email protected]> Date: Mon Feb 13 15:08:52 2023 -0500 chore: clean up Markdoc starter to essentials commit 815e2f2 Author: bholmesdev <[email protected]> Date: Mon Feb 13 14:13:02 2023 -0500 feat: content prop types for markdoc! commit 8bcd23c Author: bholmesdev <[email protected]> Date: Mon Feb 13 14:05:40 2023 -0500 feat: allow Render type injection commit cdb7e9e Author: bholmesdev <[email protected]> Date: Mon Feb 13 14:04:37 2023 -0500 chore: unused file commit 0df33ea Author: bholmesdev <[email protected]> Date: Mon Feb 13 14:04:31 2023 -0500 chore: with-markdoc strictNullChecks commit 377c6d7 Author: bholmesdev <[email protected]> Date: Fri Feb 10 17:39:35 2023 -0500 play: add docs example with Aside and Since ported commit f9f8112 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:22:47 2023 -0500 chore: remove unused options object commit c9a66bf Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:18:27 2023 -0500 chore: remove content-types. Too early! commit 67f49e8 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:18:20 2023 -0500 fix: ContentEntryType import commit 9b93d81 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:10:06 2023 -0500 chore: Markdoc working! log commit 90f7764 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:09:58 2023 -0500 test: content component dev and build commit 14559f6 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:01:10 2023 -0500 test: prod builds commit a0dcbff Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:01:04 2023 -0500 fix: stop bundling markdoc for isTag commit cb19048 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:00:53 2023 -0500 fix: avoid import if no config present (prod build error) commit bda8295 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:00:33 2023 -0500 chore: ignore `.astro` type error commit 28a6d79 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:00:12 2023 -0500 fix: remove "components" from tsconfig commit 0297bb7 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:00:01 2023 -0500 deps: add shiki for Code comp error commit e4f141e Author: bholmesdev <[email protected]> Date: Fri Feb 10 08:45:37 2023 -0500 play: make sure md also works commit dfdb35f Author: bholmesdev <[email protected]> Date: Thu Feb 9 13:25:18 2023 -0500 test: entry and collections parse commit eaf4994 Author: bholmesdev <[email protected]> Date: Thu Feb 9 13:25:07 2023 -0500 deps: devalue, test fixture commit 3f71932 Author: bholmesdev <[email protected]> Date: Thu Feb 9 13:24:47 2023 -0500 chore: remove unused dream file commit b182686 Author: bholmesdev <[email protected]> Date: Thu Feb 9 12:29:32 2023 -0500 refactor: remove fallback loader commit 0540d70 Author: bholmesdev <[email protected]> Date: Thu Feb 9 12:26:21 2023 -0500 fix: markdoc.config loading commit 575dadf Author: bholmesdev <[email protected]> Date: Thu Feb 9 12:16:18 2023 -0500 oops, forgot to commit untracked commit 9746a97 Author: bholmesdev <[email protected]> Date: Thu Feb 9 12:16:02 2023 -0500 refactor: pass file contents commit 534a658 Author: bholmesdev <[email protected]> Date: Thu Feb 9 12:13:38 2023 -0500 refactor: move plain md to content entry type commit 24df79b Author: bholmesdev <[email protected]> Date: Wed Feb 8 15:51:44 2023 -0500 wip: move mdx to collection type API commit cc44e4f Author: bholmesdev <[email protected]> Date: Wed Feb 8 15:50:52 2023 -0500 deps: mdx commit c30c1b3 Author: bholmesdev <[email protected]> Date: Wed Feb 8 10:10:39 2023 -0500 wip: scaffold content types commit 2487aed Author: bholmesdev <[email protected]> Date: Wed Feb 8 09:53:35 2023 -0500 feat: move Renderer to markdoc, get Content component! commit 44faff9 Author: bholmesdev <[email protected]> Date: Wed Feb 8 09:53:06 2023 -0500 deps: move to @astrojs/markdoc commit bef2690 Author: bholmesdev <[email protected]> Date: Tue Feb 7 16:01:34 2023 -0500 feat: addContentEntryType integration hook commit 508568f Author: bholmesdev <[email protected]> Date: Tue Feb 7 16:00:42 2023 -0500 deps: graymatter commit cb70602 Author: bholmesdev <[email protected]> Date: Tue Feb 7 14:00:27 2023 -0500 chore: unit tests commit 545246d Author: bholmesdev <[email protected]> Date: Tue Feb 7 14:00:23 2023 -0500 wip: get dream API for file loader working commit 97664e0 Author: bholmesdev <[email protected]> Date: Mon Feb 6 18:09:23 2023 -0500 wip: play with separate markdoc config commit c5d8a33 Author: bholmesdev <[email protected]> Date: Mon Feb 6 17:04:22 2023 -0500 fix: render attributes to html commit 82e30a0 Author: bholmesdev <[email protected]> Date: Mon Feb 6 17:04:14 2023 -0500 deps: stringify-attributes commit b72ba61 Author: bholmesdev <[email protected]> Date: Mon Feb 6 16:33:27 2023 -0500 fix: component render bug commit 59f1e5c Author: bholmesdev <[email protected]> Date: Mon Feb 6 16:11:15 2023 -0500 feat: basic Astro renderer in with-markdoc commit de15a72 Author: bholmesdev <[email protected]> Date: Mon Feb 6 16:11:01 2023 -0500 wip: expose Markdoc from integration commit 83bfe44 Author: bholmesdev <[email protected]> Date: Mon Feb 6 11:21:17 2023 -0500 feat: get markdoc contents commit 6f50068 Author: bholmesdev <[email protected]> Date: Mon Feb 6 11:13:57 2023 -0500 chore: integration setup * Squashed commit of `markdoc-poc` commit bd0dd9d Author: bholmesdev <[email protected]> Date: Wed Feb 15 09:43:04 2023 -0500 Revert "feat: support `.md` overrides for content collections" This reverts commit c06f83e. commit 5b9a1f3 Author: bholmesdev <[email protected]> Date: Tue Feb 14 13:48:56 2023 -0500 feat: generate `.md` types override commit e464ae8 Author: bholmesdev <[email protected]> Date: Tue Feb 14 12:56:11 2023 -0500 chore: mdoc -> md commit b74fd6a Author: bholmesdev <[email protected]> Date: Tue Feb 14 12:56:01 2023 -0500 feat: support `.md` overrides for content collections commit bdcc18a Author: bholmesdev <[email protected]> Date: Tue Feb 14 12:30:48 2023 -0500 deps: remove html-escaper commit f44b57f Author: bholmesdev <[email protected]> Date: Tue Feb 14 12:30:42 2023 -0500 fix: remove unneeded html-escaper commit fb79194 Author: bholmesdev <[email protected]> Date: Tue Feb 14 12:08:04 2023 -0500 fix: type inferencing in preview commit 0c05034 Author: bholmesdev <[email protected]> Date: Tue Feb 14 11:32:19 2023 -0500 fix: import types from @astrojs/markdoc commit 57e741a Author: bholmesdev <[email protected]> Date: Tue Feb 14 11:28:33 2023 -0500 refactor: remove unneeded async commit b19d854 Author: bholmesdev <[email protected]> Date: Tue Feb 14 10:26:20 2023 -0500 fix: lock commit b1083a1 Author: bholmesdev <[email protected]> Date: Tue Feb 14 10:19:50 2023 -0500 nit: 0.0.0 to avoid version bump commit 71891eb Author: bholmesdev <[email protected]> Date: Tue Feb 14 09:33:27 2023 -0500 chore: changeset commit 444752a Author: bholmesdev <[email protected]> Date: Tue Feb 14 09:30:10 2023 -0500 docs: add note on Aside src commit 619d4b3 Author: bholmesdev <[email protected]> Date: Tue Feb 14 09:25:56 2023 -0500 nit: reorder type import commit e914da0 Author: bholmesdev <[email protected]> Date: Tue Feb 14 09:25:38 2023 -0500 refactor: clean up astroNode commit 2dfc226 Author: bholmesdev <[email protected]> Date: Tue Feb 14 09:08:56 2023 -0500 docs: README edits commit 3c7b85c Author: bholmesdev <[email protected]> Date: Tue Feb 14 09:07:29 2023 -0500 docs: change with-markdoc title commit 29cdea9 Author: bholmesdev <[email protected]> Date: Mon Feb 13 18:29:10 2023 -0500 docs: add usage and examples to Markdoc README commit e397a80 Author: bholmesdev <[email protected]> Date: Mon Feb 13 18:18:54 2023 -0500 fix: line endings in test commit f9ebf59 Author: bholmesdev <[email protected]> Date: Mon Feb 13 18:09:15 2023 -0500 docs: @astrojs/markdoc README intro commit 7800e9c Author: bholmesdev <[email protected]> Date: Mon Feb 13 18:08:07 2023 -0500 docs: update example README commit f0b900a Author: bholmesdev <[email protected]> Date: Mon Feb 13 18:04:34 2023 -0500 chore: remove markdoc.config loader commit 3f040e4 Author: bholmesdev <[email protected]> Date: Mon Feb 13 17:58:52 2023 -0500 chore: remove unused fixture dep commit b2ea6c2 Author: bholmesdev <[email protected]> Date: Mon Feb 13 17:58:25 2023 -0500 fix: glob for single content extension commit f4e171c Author: bholmesdev <[email protected]> Date: Mon Feb 13 15:10:39 2023 -0500 chore: remove unused deps commit d9095d0 Author: bholmesdev <[email protected]> Date: Mon Feb 13 15:10:31 2023 -0500 chore: unused style tag commit a5435f1 Author: bholmesdev <[email protected]> Date: Mon Feb 13 15:08:52 2023 -0500 chore: clean up Markdoc starter to essentials commit 815e2f2 Author: bholmesdev <[email protected]> Date: Mon Feb 13 14:13:02 2023 -0500 feat: content prop types for markdoc! commit 8bcd23c Author: bholmesdev <[email protected]> Date: Mon Feb 13 14:05:40 2023 -0500 feat: allow Render type injection commit cdb7e9e Author: bholmesdev <[email protected]> Date: Mon Feb 13 14:04:37 2023 -0500 chore: unused file commit 0df33ea Author: bholmesdev <[email protected]> Date: Mon Feb 13 14:04:31 2023 -0500 chore: with-markdoc strictNullChecks commit 377c6d7 Author: bholmesdev <[email protected]> Date: Fri Feb 10 17:39:35 2023 -0500 play: add docs example with Aside and Since ported commit f9f8112 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:22:47 2023 -0500 chore: remove unused options object commit c9a66bf Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:18:27 2023 -0500 chore: remove content-types. Too early! commit 67f49e8 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:18:20 2023 -0500 fix: ContentEntryType import commit 9b93d81 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:10:06 2023 -0500 chore: Markdoc working! log commit 90f7764 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:09:58 2023 -0500 test: content component dev and build commit 14559f6 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:01:10 2023 -0500 test: prod builds commit a0dcbff Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:01:04 2023 -0500 fix: stop bundling markdoc for isTag commit cb19048 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:00:53 2023 -0500 fix: avoid import if no config present (prod build error) commit bda8295 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:00:33 2023 -0500 chore: ignore `.astro` type error commit 28a6d79 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:00:12 2023 -0500 fix: remove "components" from tsconfig commit 0297bb7 Author: bholmesdev <[email protected]> Date: Fri Feb 10 09:00:01 2023 -0500 deps: add shiki for Code comp error commit e4f141e Author: bholmesdev <[email protected]> Date: Fri Feb 10 08:45:37 2023 -0500 play: make sure md also works commit dfdb35f Author: bholmesdev <[email protected]> Date: Thu Feb 9 13:25:18 2023 -0500 test: entry and collections parse commit eaf4994 Author: bholmesdev <[email protected]> Date: Thu Feb 9 13:25:07 2023 -0500 deps: devalue, test fixture commit 3f71932 Author: bholmesdev <[email protected]> Date: Thu Feb 9 13:24:47 2023 -0500 chore: remove unused dream file commit b182686 Author: bholmesdev <[email protected]> Date: Thu Feb 9 12:29:32 2023 -0500 refactor: remove fallback loader commit 0540d70 Author: bholmesdev <[email protected]> Date: Thu Feb 9 12:26:21 2023 -0500 fix: markdoc.config loading commit 575dadf Author: bholmesdev <[email protected]> Date: Thu Feb 9 12:16:18 2023 -0500 oops, forgot to commit untracked commit 9746a97 Author: bholmesdev <[email protected]> Date: Thu Feb 9 12:16:02 2023 -0500 refactor: pass file contents commit 534a658 Author: bholmesdev <[email protected]> Date: Thu Feb 9 12:13:38 2023 -0500 refactor: move plain md to content entry type commit 24df79b Author: bholmesdev <[email protected]> Date: Wed Feb 8 15:51:44 2023 -0500 wip: move mdx to collection type API commit cc44e4f Author: bholmesdev <[email protected]> Date: Wed Feb 8 15:50:52 2023 -0500 deps: mdx commit c30c1b3 Author: bholmesdev <[email protected]> Date: Wed Feb 8 10:10:39 2023 -0500 wip: scaffold content types commit 2487aed Author: bholmesdev <[email protected]> Date: Wed Feb 8 09:53:35 2023 -0500 feat: move Renderer to markdoc, get Content component! commit 44faff9 Author: bholmesdev <[email protected]> Date: Wed Feb 8 09:53:06 2023 -0500 deps: move to @astrojs/markdoc commit bef2690 Author: bholmesdev <[email protected]> Date: Tue Feb 7 16:01:34 2023 -0500 feat: addContentEntryType integration hook commit 508568f Author: bholmesdev <[email protected]> Date: Tue Feb 7 16:00:42 2023 -0500 deps: graymatter commit cb70602 Author: bholmesdev <[email protected]> Date: Tue Feb 7 14:00:27 2023 -0500 chore: unit tests commit 545246d Author: bholmesdev <[email protected]> Date: Tue Feb 7 14:00:23 2023 -0500 wip: get dream API for file loader working commit 97664e0 Author: bholmesdev <[email protected]> Date: Mon Feb 6 18:09:23 2023 -0500 wip: play with separate markdoc config commit c5d8a33 Author: bholmesdev <[email protected]> Date: Mon Feb 6 17:04:22 2023 -0500 fix: render attributes to html commit 82e30a0 Author: bholmesdev <[email protected]> Date: Mon Feb 6 17:04:14 2023 -0500 deps: stringify-attributes commit b72ba61 Author: bholmesdev <[email protected]> Date: Mon Feb 6 16:33:27 2023 -0500 fix: component render bug commit 59f1e5c Author: bholmesdev <[email protected]> Date: Mon Feb 6 16:11:15 2023 -0500 feat: basic Astro renderer in with-markdoc commit de15a72 Author: bholmesdev <[email protected]> Date: Mon Feb 6 16:11:01 2023 -0500 wip: expose Markdoc from integration commit 83bfe44 Author: bholmesdev <[email protected]> Date: Mon Feb 6 11:21:17 2023 -0500 feat: get markdoc contents commit 6f50068 Author: bholmesdev <[email protected]> Date: Mon Feb 6 11:13:57 2023 -0500 chore: integration setup * feat: add `--perf` flag to skip md plugins * wip: performance pkg with md fixture * refactor: move rendering to util * refactor: generate posts instead of commiting * deps: npm-run-all * chore: mdoc and mdx fixtures * chore: remove generated files from git * chore: lockfile * chore: remove .astro types from remote * refactor: --perf -> --internal-ci-perf * chore: log ext and directory on write * refactor: --perf -> env var * feat: add perf benchmark check to mdx * refactor: isPerfBenchmark * chore: refine generated ignore * feat: test simple and with-components cases * chore: remove old --internal-ci reference * refactor: ASTRO_CI_PERFORMANCE_RUN -> ASTRO_PERFORMANCE_BENCHMARK * chore: remove accidental file * feat: add react-component render benchmark * chore: add `--format` flag to benchmark * refactor: move markdoc transform to build time * docs: only used in content collections Co-authored-by: Sarah Rainsberger <[email protected]> * chore: use Markdoc terms for transform * refactor: remove Markdoc export * refactor: remove advanced component API * test: update fixture to match new config * chore: with-markdoc filetree * docs: add "exclusively" to README * docs: query for -> query your collection * docs: update config to new Markdoc options * docs: astro-ui-frameworks -> astro-components * edit: add client component instructions * nit: add "today" to imply future support * docs: add separate HTML and component examples * fix: inconsistent tabs v spaces * fix: indentation * deps: zod * chore: check components are capitalized names * chore: raise error if no matching component found * chore: hand `mjs` highlighting in error overlay * chore: validate tags and nodes * refactor: use MarkdocError on render errors * fix: handle possible cache miss * chore: use error hint * test: update Markdoc node config test * chore: clarify Markdoc config * docs: reshuffle note * chore: update to `nodes` rec * docs: clarify Markdoc attributes * docs: add editor integration * chore: update example coding challenge * chore: update DocsContent comments * fix: cant find zod for some reason * fix: potentially unreliable cache * chore: remove revealSecret from ex * wip: forward slash?? * fix: forward slash. * chore: lint * chore: ignore statements * chore: clarify semi-private hooks * docs: with-mdx -> with-markdoc Co-authored-by: Sarah Rainsberger <[email protected]> * nit: don't capitalize cc Co-authored-by: Sarah Rainsberger <[email protected]> * docs: ::: Co-authored-by: Sarah Rainsberger <[email protected]> * nit: remove IFFE * chore: remove accidental changelog * nit: attempt pathToFileURL * nit: tested if * fix: smartypants should be avoided in benchmark! * nit: remove `any` * nit: extract component zod obj * fix: move validateComponents to render comp * nit: remove unused return * nit: move shiki highlighter consts to outer scope * nit: remove `any` from mdx * refactor: add type defs for private integration hooks * fix: type error in mdx defaults * fix: broke extendMarkdownConfig, oops! * Revert "nit: attempt pathToFileURL" This reverts commit 45fac99. * fix: only validate when components is defined * fix: remove types from git * fix: migrate mdoc perf benchmark to new config * chore: delete more sneaky types * docs: add usage to changeset * docs: update config example in README * docs: add manual rendering instructions * Update examples/with-markdoc/README.md Co-authored-by: Sarah Rainsberger <[email protected]> * docs: reorder configuration options * docs: "see the next section" * chore: add numPosts as a benchmark flag * chore: bump to minor changesets for MDX * chore: update TODO docs links * docs: update component key naming and node instr * docs: redraft markdoc runtime config intro * Squashed commit of the following: commit fbab73c Author: matthewp <[email protected]> Date: Tue Mar 7 16:38:11 2023 +0000 [ci] format commit a206106 Author: Matthew Phillips <[email protected]> Date: Tue Mar 7 11:35:54 2023 -0500 Expose the ssr manifest (#6435) * Expose the ssr manifest * Add changeset * Add types for virtual mod commit 2751584 Author: Princesseuh <[email protected]> Date: Tue Mar 7 15:14:15 2023 +0000 [ci] format commit 694918a Author: Erika <[email protected]> Date: Tue Mar 7 16:12:21 2023 +0100 Implement RFC "A core story for images" (#6344) * feat(assets): Add Vite plugin * feat(images): Set up Image component * fix(types): Attempt to fix type generation * Revert "fix(types): Attempt to fix type generation" This reverts commit 063aa27. * fix(image): Fix image types causing build to fail * feat(image): Implement client side part * feat(services): Allow arbitrary transforms parameters * fix(image): Fix paths and types * config(types): Update config types to provide completions for available services * feat(image): Add serving in dev * feat(image): Improve type error messages * refactor(image): Move sharp's parseParams to baseService * refactor(image): Skip work in dev for remote servies * feat(image): Add support for remote images * feat(image): Add squoosh service * chore: update export map * refactor(image): Abstract attributes handling by services * config(vercel): Remove test image service * feat(image): Support for relative images in Markdown (WIP) * feat(images): Add support for relative images in Markdown * feat(image): Update with RFC feedback * fix(image): Fix alt error on getImage * feat(image): Add support for assets validation through content collections * feat(image): Remove validateTransform * feat(image): Move to assets folder * fix(image): Fix package exports * feat(image): Add static imports references to virtual moduel * fix(image): Fix images from content collections not working when embedded * chore: lockfile * fix(markdown): Fix type * fix(images): Flag enhanced images behing an experimental flag * config(example): Update images example conifg * fix(image): Fix types * fix(image): Fix asset type for strict, allow arbritary input and output formats * chore: fix example check * feat(image): Emit assets for ESM imported images * Add initial core image tests (#6381) * feat(images): Make frontmatter extraction more generic than images for future * feat(image): Add support for building * fix(image): Fix types * fix(images): Fix compatibility with image integration * feat(images): Cuter generation stats * fix(images): Globals are unsafe, it turns out * fix(images): Only generate images if flag is enabled * fix(images): Only create `addStaticImage` in build * feat(images): Add SSR endpoint * fix(images): Only inject route in SSR * Add tests for SSR * Remove console.log * Updated lockfile * rename to satisfy the link gods * skip build tests for now * fix(images): Fix WASM files not being copied in dev * feat(images): Add quality presets * fix build tests running * Remove console.log * Add tests for getImage * Test local services * Test the content collections API * Add tests for quality * Skipping content collections test * feat(image): Add support for `~/assets` alias * test(image): Add tests for aliases in dev * Fix windows + content collections * test(image): Add tests for aliased images and images in Markdown * Fix markdown images being built * Should be posix join * Use the optimized image * fix test * Fixes windows smoke * fix(image): Nits * feat(images): Add automatic update for `env.d.ts` when experimental images are enabled * fix(images): Revert env.d.ts change if the user opted-out of the experimental image support * chore: remove bad image example project * feat(image): Rename `experimental.images` to `experimental.assets` * fix(images): Remove unused code in MDX integration * chore: Remove unrelated change * fix(images): Remove export from astro/components * Fix, esm import on Win * test(images): Add test for format * fix(images): Add `client-image.d.ts` to export map * chore: changeset * fix(images): Adjust with feedback, no more automatic refine, asset() -> image() * fix(images): Fix types * fix(images): Remove unnecessary spread * fix(images): Better types for parseUrl and transform * fix(images): Fix types * fix(images): Adjust from feedback * fix(images): Pass width and height through getHTMLAttributes even if they're not added by the uesr * fix(images): Recusirsively extract frontmatter assets * fix(images): Use a reduce instead * feat(images): Add support for data: URIs * chore: changeset * docs(images): Misc docs fixes * Update .changeset/gold-rocks-cry.md Co-authored-by: Chris Swithinbank <[email protected]> * Update .changeset/gold-rocks-cry.md Co-authored-by: Sarah Rainsberger <[email protected]> * Update packages/astro/src/@types/astro.ts Co-authored-by: Chris Swithinbank <[email protected]> * Update packages/astro/src/assets/services/service.ts Co-authored-by: Chris Swithinbank <[email protected]> * Update packages/astro/src/assets/services/service.ts Co-authored-by: Chris Swithinbank <[email protected]> * Update packages/astro/src/assets/services/service.ts Co-authored-by: Chris Swithinbank <[email protected]> * Update packages/astro/src/assets/types.ts Co-authored-by: Chris Swithinbank <[email protected]> * Update packages/astro/src/assets/types.ts Co-authored-by: Chris Swithinbank <[email protected]> --------- Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Chris Swithinbank <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]> commit 377530a Author: ematipico <[email protected]> Date: Tue Mar 7 13:43:21 2023 +0000 [ci] format commit fe88f89 Author: Emanuele Stoppa <[email protected]> Date: Tue Mar 7 13:41:24 2023 +0000 chore: use directive `@ts-expect-error` instead of `@ts-ignore` (#6429) commit e1858e6 Author: ematipico <[email protected]> Date: Tue Mar 7 06:57:52 2023 +0000 [ci] format commit 75921b3 Author: Emanuele Stoppa <[email protected]> Date: Tue Mar 7 06:55:41 2023 +0000 feat(cli): add `--watch` to `astro check` command (#6356) * feat(cli): add `--watch` to `astro check` command * chore: refactor in a leaner way, logic not changed * chore: lint * chore: revert changes in sync command * chore: tweak server settings * test: add one test case * chore: increase timeout * test: predictable testing * chore: add changeset * chore: code suggestions * code suggestions * chore: use directly `chokidar` * chore: tweak code * fix: open documents first * chore: disable test * chore: code suggestions * chore: code suggestions * Apply suggestions from code review Co-authored-by: Erika <[email protected]> * code suggestions * chore: rebase --------- Co-authored-by: Erika <[email protected]> commit 1291afc Author: Bjorn Lu <[email protected]> Date: Tue Mar 7 14:50:34 2023 +0800 Fix changeset run (#6442) commit 00a0af7 Author: Bjorn Lu <[email protected]> Date: Tue Mar 7 10:52:47 2023 +0800 Move benchmark package and update changeset config (#6433) commit af05a4f Author: Nate Moore <[email protected]> Date: Mon Mar 6 14:06:33 2023 -0600 Update README.md (#6437) * Update README.md * Update README.md commit 8ebf4b7 Author: Nate Moore <[email protected]> Date: Mon Mar 6 14:03:33 2023 -0600 chore: update branding assets (#6436) commit afbbc4d Author: Erika <[email protected]> Date: Mon Mar 6 19:57:16 2023 +0100 Update compilation target for Node 16 (#6213) * config(esbuild): Update esbuild target to node16 * config(package): Update root package.json node engine * config(tsconfig): Update all the tsconfigs module and targets * chore: changeset * chore: remove unneeded file commit 18acae3 Author: Sarah Rainsberger <[email protected]> Date: Mon Mar 6 14:36:40 2023 -0400 [error docs] update link for client-side scripts (#6423) commit 8b49d17 Author: ematipico <[email protected]> Date: Mon Mar 6 17:03:18 2023 +0000 [ci] format commit a4a74ab Author: Emanuele Stoppa <[email protected]> Date: Mon Mar 6 16:58:56 2023 +0000 feat(cli): add help flags to various commands (#6394) Co-authored-by: Happydev <[email protected]> commit b087b83 Author: Dennis Morello <[email protected]> Date: Mon Mar 6 17:38:42 2023 +0100 Add getStaticPaths type helpers to infer params and props (#6150) * feat(astro): add InferGetStaticParamsType and InferGetStaticPropsType type helpers * chore(astro): added changeset commit 19fe4cb Author: Houston (Bot) <[email protected]> Date: Mon Mar 6 08:30:38 2023 -0800 [ci] release (#6414) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Revert "Squashed commit of the following:" This reverts commit fbe129b. * feat: add mdx backwards compat to make nonbreaking * chore: add comment on error code * Revert "chore: bump to minor changesets for MDX" This reverts commit 3e99783. --------- Co-authored-by: Sarah Rainsberger <[email protected]>

github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 24, 2023

ematipico force-pushed the feature/check-watch branch 4 times, most recently from 7de9551 to 7a303fa Compare February 27, 2023 14:36

ematipico force-pushed the feature/check-watch branch 2 times, most recently from 230d21a to 34d840d Compare February 28, 2023 15:45

github-actions bot added the semver: minor Change triggers a `minor` release label Feb 28, 2023

github-actions bot requested changes Feb 28, 2023

View reviewed changes

ematipico marked this pull request as ready for review February 28, 2023 15:57

github-actions bot requested changes Feb 28, 2023

View reviewed changes

ematipico mentioned this pull request Feb 28, 2023

document --watch for astro check command withastro/docs#2759

Merged

matthewp reviewed Feb 28, 2023

View reviewed changes

packages/astro/test/cli.test.js Outdated Show resolved Hide resolved

matthewp reviewed Feb 28, 2023

View reviewed changes

packages/astro/test/test-utils.js Outdated Show resolved Hide resolved

ematipico requested a review from matthewp February 28, 2023 17:23

github-actions bot previously requested changes Feb 28, 2023

View reviewed changes

matthewp approved these changes Mar 1, 2023

View reviewed changes

Princesseuh reviewed Mar 1, 2023

View reviewed changes

packages/astro/src/cli/check/index.ts Outdated Show resolved Hide resolved

packages/astro/src/cli/check/index.ts Outdated Show resolved Hide resolved

packages/astro/src/cli/check/index.ts Outdated Show resolved Hide resolved

ematipico force-pushed the feature/check-watch branch 6 times, most recently from 15ababc to 3a59e9f Compare March 2, 2023 14:24

bluwy reviewed Mar 2, 2023

View reviewed changes

bluwy approved these changes Mar 6, 2023

View reviewed changes

Princesseuh approved these changes Mar 6, 2023

View reviewed changes

ematipico and others added 20 commits March 6, 2023 17:01

feat(cli): add --watch to astro check command

9359111

chore: refactor in a leaner way, logic not changed

6574e28

chore: lint

79c3ca1

chore: revert changes in sync command

baeaa4a

chore: tweak server settings

5c38908

test: add one test case

a532e1f

chore: increase timeout

181832e

test: predictable testing

6ff2948

chore: add changeset

e6879ed

chore: code suggestions

4746389

code suggestions

f191ba6

chore: use directly chokidar

1d5961a

chore: tweak code

b2d9c05

fix: open documents first

6e02590

chore: disable test

512a1db

chore: code suggestions

c7e2efc

chore: code suggestions

9dd9c19

Apply suggestions from code review

00e0483

Co-authored-by: Erika <[email protected]>

code suggestions

1d72f39

chore: rebase

6fdc02d

ematipico force-pushed the feature/check-watch branch from 73040f2 to 6fdc02d Compare March 6, 2023 17:13

chore: rebase

ba8c3b8

ematipico merged commit 75921b3 into main Mar 7, 2023

ematipico deleted the feature/check-watch branch March 7, 2023 06:55

astrobot-houston mentioned this pull request Mar 7, 2023

[ci] release #6432

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cli): add `--watch` to `astro check` command #6356

feat(cli): add `--watch` to `astro check` command #6356

ematipico commented Feb 24, 2023 •

edited

Loading

changeset-bot bot commented Feb 24, 2023 •

edited

Loading

ematipico commented Feb 27, 2023

github-actions bot commented Feb 27, 2023

github-actions bot left a comment

github-actions bot left a comment

matthewp Feb 28, 2023

matthewp commented Feb 28, 2023

github-actions bot left a comment

bluwy left a comment

		@@ -0,0 +1,2 @@
		// Having a `tsconfig.json`, even empty speeds up the test massively since TypeScript does not have to look for one

feat(cli): add --watch to astro check command #6356

feat(cli): add --watch to astro check command #6356

Conversation

ematipico commented Feb 24, 2023 • edited Loading

Changes

Testing

Docs

changeset-bot bot commented Feb 24, 2023 • edited Loading

🦋 Changeset detected

ematipico commented Feb 27, 2023

github-actions bot commented Feb 27, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

matthewp Feb 28, 2023

Choose a reason for hiding this comment

matthewp commented Feb 28, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

bluwy left a comment

Choose a reason for hiding this comment

feat(cli): add `--watch` to `astro check` command #6356

feat(cli): add `--watch` to `astro check` command #6356

ematipico commented Feb 24, 2023 •

edited

Loading

changeset-bot bot commented Feb 24, 2023 •

edited

Loading