-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Tailwind & Turbolinks integration descriptions more consistent #6419
Conversation
🦋 Changeset detectedLatest commit: 55b7dda The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit after my own heart. 💜
It's beautiful 🥹 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it! Thank you @Yan-Thomas 💜
We should add a patch changeset to this PR so that these updates also make it to npm.
One thing we could think about looking at https://astro.build/integrations/official/ is making these a bit more descriptive too.
Some examples of other descriptions there:
Use React components within Astro
Faster page navigations by prefetching links when the browser is idle.
I’ve made some suggestions and also suggested adding “Deprecated” to the Turbolinks description. Happy for you to make the final call though!
Co-authored-by: Chris Swithinbank <[email protected]>
Marking this as a draft so we can discuss more about these descriptions internally before merging. |
This should be good now 👍, will add another PR updating other integrations titles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yan!
Changes
This PR changes the
package.json
description for the Tailwind and Turbolinks integrations to make them more consistent with the Partytown one.Testing
No code changes!
Docs
It's all docs!
/cc @withastro/maintainers-docs