Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify internal resolver in dev #6576

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Simplify internal resolver in dev #6576

merged 1 commit into from
Mar 18, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 17, 2023

Changes

This cleans up our .jsx -> .tsx handling. The code is removed since it's already handled at

// Try resolve jsx to tsx
if (!resultId && id.endsWith('.jsx')) {
resultId = await loader.resolveId(id.slice(0, -4), undefined);
}

This should prevent Vite's perf PR (vitejs/vite#12450) from breaking for a specific case, where the user project imports .tsx components that's outside of the project root.

Testing

n/a. Existing tests should pass.

Docs

n/a. code refactor and cleanup.

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2023

🦋 Changeset detected

Latest commit: 36253f4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 17, 2023
Copy link
Member

@MoustaphaDev MoustaphaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks for catching this one!

@bluwy bluwy merged commit 3881901 into main Mar 18, 2023
@bluwy bluwy deleted the simplify-dev-resolve branch March 18, 2023 09:58
@astrobot-houston astrobot-houston mentioned this pull request Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants