Bump vite to 4.4.6

[birkskyum]

Changes

This bumps Vite to 4.4.6 (Astro is currently at 4.3.9). It includes patch bumps to all the adapters.

This brings experimental support for Lightning CSS (vite 4.4.0) and improved support for Bun (vite 4.4.6).

Two ts-expect-error flags are obsolete and removed, because Vite now use esbuild 0.18

Testing

Existing unit tests and e2e tests should still pass.

Docs

/cc @withastro/maintainers-docs for feedback!

There is currently no section on Lightning CSS.

[changeset-bot]

🦋 Changeset detected

Latest commit: aa24751

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Princesseuh]

@bluwy was there any reasons we weren't already on 4.4?

[bluwy]

@bluwy was there any reasons we weren't already on 4.4?

Mostly that we're not using any 4.4 specific features, and users can bump to 4.4 if they want to themselves. But also, 4.4 started with quite some regressions that I initially hold off, but it's safer now.

The e2e failing seems to be legit though. Might need to address that before merging, could be a Vite regression.

[birkskyum]

I tried updating solid-js 1.7.6 -> 1.7.8 (latest), but it doesn't resolve "Circular imports with Solid › Context" test breaks in E2E. This issue appeared first in vite "4.4.0-beta.0"

[birkskyum]

@bluwy , to debug this further, how can I as an Astro user use a custom version of Vite like you suggest?

[bluwy]

You can run npm update vite in your project to use a different Vite version for Astro.

I can try to take a look at the issue over the weekend. A bit swamped at the moment 😅

[birkskyum]

I found that replacing client:only with client:load can makes test pass. It's odd the test has a client:only without a framework hint, because the docs mention it's mandatory, but it doesn't appear to always throw https://docs.astro.build/en/reference/errors/no-client-only-hint/.

This appear a bit off-topic, so I made a separate issue for it here #7771

[birkskyum]

Turns out simply using import type when importing solid-js "Component" type was sufficient for the test to pass.

[bluwy]

Thanks for fixing the tests! This make sense to me as Vite's esbuild now understand our tsconfig.json's verbatimModuleSyntax: true config which causes the type elision to no work correctly. Not really sure if this is a Vite regression, but I'll keep watch of this.

[birkskyum]

Rebased. Tests will pass if rerun (they were just cancelled).

Requested changes addressed