Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove webapi in favor of a smaller polyfill #7840

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Jul 27, 2023

Changes

This PR removes the @astrojs/webapi package completely, instead replacing it with a very small polyfill. @astrojs/webapi used to be necessary, but Node has gotten pretty good over the years at supporting many of those APIs natively, and for the rest, we mainly provided no-op anyway.

image

Testing

Tests should still pass!

Docs

N/A

@Princesseuh Princesseuh requested a review from a team as a code owner July 27, 2023 14:09
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

🦋 Changeset detected

Latest commit: 2af1b21

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Jul 27, 2023
@Princesseuh Princesseuh marked this pull request as draft July 27, 2023 14:11
@Princesseuh Princesseuh marked this pull request as ready for review July 27, 2023 15:01
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we are not yet ready to delete the @astrojs/webapi package.

  1. We have to make a major on npm;
  2. We have to deprecate it in that major on npm, so people will get a notification when it's installed;

(BTW, I totally got the easter egg 🏴‍☠️ )

@Princesseuh
Copy link
Member Author

I believe we are not yet ready to delete the @astrojs/webapi package.

  1. We have to make a major on npm;
  2. We have to deprecate it in that major on npm, so people will get a notification when it's installed;

(BTW, I totally got the easter egg 🏴‍☠️ )

This is to be merged in next, so we can do this whenever we'll actually release 3.0

@ematipico
Copy link
Member

This is to be merged in next, so we can do this whenever we'll actually release 3.0

I hope you know how, because I wouldn't know how to do if the files don't exist anymore 🤣 (even in next branch)

@Princesseuh Princesseuh merged commit b4a83b9 into next Jul 27, 2023
13 checks passed
@Princesseuh Princesseuh deleted the feat/no-webapi branch July 27, 2023 16:24
ematipico pushed a commit that referenced this pull request Jul 31, 2023
* feat: remove webapi in favor of a smaller polyfill

* test: remove old test

* test: 🤦‍♀️

* chore: changeset
ematipico pushed a commit that referenced this pull request Aug 1, 2023
* feat: remove webapi in favor of a smaller polyfill

* test: remove old test

* test: 🤦‍♀️

* chore: changeset
ematipico pushed a commit that referenced this pull request Aug 1, 2023
* feat: remove webapi in favor of a smaller polyfill

* test: remove old test

* test: 🤦‍♀️

* chore: changeset
ematipico pushed a commit that referenced this pull request Aug 3, 2023
* feat: remove webapi in favor of a smaller polyfill

* test: remove old test

* test: 🤦‍♀️

* chore: changeset
ematipico pushed a commit that referenced this pull request Aug 8, 2023
* feat: remove webapi in favor of a smaller polyfill

* test: remove old test

* test: 🤦‍♀️

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants