-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove webapi in favor of a smaller polyfill #7840
Conversation
🦋 Changeset detectedLatest commit: 2af1b21 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
102a4f6
to
b3f4963
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we are not yet ready to delete the @astrojs/webapi
package.
- We have to make a major on npm;
- We have to deprecate it in that major on npm, so people will get a notification when it's installed;
(BTW, I totally got the easter egg 🏴☠️ )
This is to be merged in |
I hope you know how, because I wouldn't know how to do if the files don't exist anymore 🤣 (even in |
* feat: remove webapi in favor of a smaller polyfill * test: remove old test * test: 🤦♀️ * chore: changeset
* feat: remove webapi in favor of a smaller polyfill * test: remove old test * test: 🤦♀️ * chore: changeset
* feat: remove webapi in favor of a smaller polyfill * test: remove old test * test: 🤦♀️ * chore: changeset
* feat: remove webapi in favor of a smaller polyfill * test: remove old test * test: 🤦♀️ * chore: changeset
* feat: remove webapi in favor of a smaller polyfill * test: remove old test * test: 🤦♀️ * chore: changeset
Changes
This PR removes the
@astrojs/webapi
package completely, instead replacing it with a very small polyfill.@astrojs/webapi
used to be necessary, but Node has gotten pretty good over the years at supporting many of those APIs natively, and for the rest, we mainly provided no-op anyway.Testing
Tests should still pass!
Docs
N/A