-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(@astrojs/cloudflare): port functionPerRoute #8078
feature(@astrojs/cloudflare): port functionPerRoute #8078
Conversation
🦋 Changeset detectedLatest commit: 17c27c8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much for tackling this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we have to update the README.md
, and explain that functionPerRoute
is only available when mode
is "directory"
.
Co-authored-by: Emanuele Stoppa <[email protected]>
please review:
/cc @withastro/maintainers-docs for feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alexanderniebuhr ! Thanks for your patience as we're juggling both docs for the current branch that need to be published sooner and these docs for the next branch that won't go live until the end of the month! 😄
I've left a few suggestions (one of them has me shaking my fist at GitHub) for your consideration!
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexanderniebuhr, this looks great! Added two small nit comments, after these are addressed LGTM.
Co-authored-by: Yan Thomas <[email protected]>
Co-authored-by: Yan Thomas <[email protected]>
Thanks so much again @alexanderniebuhr! |
Changes
Testing
Docs
Since the changelog is copied from an already merged PR, I don't think we need to review it again