Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dotfiles in dist #8092

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Cleanup dotfiles in dist #8092

merged 4 commits into from
Aug 16, 2023

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Aug 15, 2023

Changes

  • Closes node_modules in dist folder #7933, plt-789
  • Ensure dotfiles are cleaned up after static build
  • This can happen when node_modules/.pnpm is present in the build output

Testing

Manually tested the repro in #7933, could no longer repro

Docs

N/A, bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2023

🦋 Changeset detected

Latest commit: f6041a1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 15, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I'm also confused how the node_modules ended in the dist.

@natemoo-re
Copy link
Member Author

LGTM. But I'm also confused how the node_modules ended in the dist.

Yeah, that's a good point. I think the emitted file from the injectRoute kept the original source path? We can fix that in a follow-up for sure.

@natemoo-re natemoo-re merged commit 7177f75 into main Aug 16, 2023
13 checks passed
@natemoo-re natemoo-re deleted the fix/dist-dotfiles branch August 16, 2023 14:20
This was referenced Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node_modules in dist folder
2 participants