Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add provenance to packages #8737

Merged
merged 1 commit into from
Oct 3, 2023
Merged

feat: add provenance to packages #8737

merged 1 commit into from
Oct 3, 2023

Conversation

ematipico
Copy link
Member

Changes

This PR adds the provenance field to all our packages.

More info about what the provenance statement stands for: https://docs.npmjs.com/generating-provenance-statements

Testing

Merge and release the packages

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

🦋 Changeset detected

Latest commit: e6bf864

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Oct 3, 2023
bluwy
bluwy approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would say it bugs me a little that publishConfig is under dependencies/devDependencies, it's usually somewhere above "scripts", but I won't die on this hill 😄

@ematipico ematipico merged commit 6f60da8 into main Oct 3, 2023
13 checks passed
@ematipico ematipico deleted the feat/provenance branch October 3, 2023 14:25
@astrobot-houston astrobot-houston mentioned this pull request Oct 3, 2023
Merged
@bluwy bluwy mentioned this pull request Oct 3, 2023
Merged
martrapp pushed a commit that referenced this pull request Oct 4, 2023
@ematipico @martrapp
feat: add provenance to packages (#8737)
8eed6cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ematipico @bluwy