Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Content collections] z.object wrapper for schemas #2335

Merged
merged 4 commits into from
Jan 12, 2023
Merged

[Content collections] z.object wrapper for schemas #2335

merged 4 commits into from
Jan 12, 2023

Conversation

bholmesdev
Copy link
Contributor

What kind of changes does this PR include?

  • New or updated content

Description

  • Add z.object wrapper around schema definitions. This is now a required wrapper!

@netlify
Copy link

netlify bot commented Jan 10, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit decf4aa
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63bd8f33461c40000ad0b64f
😎 Deploy Preview https://deploy-preview-2335--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bholmesdev bholmesdev mentioned this pull request Jan 10, 2023
Merged
yanthomasdev
yanthomasdev approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

delucis
delucis reviewed Jan 10, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben! Left a couple of nits but otherwise LGTM. (Helpfully my nits are in the wrong places thanks to GitHub’s UI.)

src/pages/en/guides/content-collections.mdx Show resolved Hide resolved
src/pages/en/guides/content-collections.mdx Show resolved Hide resolved
sarah11918
sarah11918 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Ben! Leaving to Chris for the final say!

@sarah11918 sarah11918 added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label Jan 10, 2023
delucis
delucis approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s a wrap!

@bholmesdev bholmesdev merged commit a37e437 into main Jan 12, 2023
@bholmesdev bholmesdev deleted the edit/schema-object-requirement branch January 12, 2023 17:44
@Acccent Acccent mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees
No one assigned
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bholmesdev @delucis @sarah11918 @yanthomasdev