Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server-side-rendering.mdx and integrations-reference.mdx #7498

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

morinokami
Copy link
Contributor

Description (required)

  • Corrected the spelling of "NodeJS" and "NodeJs" to the official "Node.js".
  • Removed redundant sections in server-side-rendering.mdx.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 25, 2024 6:23pm

Comment on lines -132 to -142
You can then choose to override the default on-demand rendering of `server` mode on any page or route by exporting `const prerender = true`:

```astro title="src/pages/my-static-page.astro" ins={2}
---
export const prerender = true;
// ...
---
<html>
<!-- Static, pre-rendered page here... -->
</html>
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method for opting into pre-rendering in server mode is described immediately below, and it seems to be redundant. So, I think this part can be safely removed.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call @morinokami ! Thank you!

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. labels Mar 25, 2024
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants