This repository has been archived by the owner on Oct 11, 2022. It is now read-only.
Upgrade apollo-cache-inmemory #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If tests pass here @mxstbr I'm going to include this in our prod cut today. |
mxstbr
approved these changes
Dec 19, 2018
|
Just a note that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
Ref apollographql/apollo-client#4210
Before this change, a memory leak problem in
apollo-cache-inmemorywould cause heap usage to rise continuously as optimistic updates were performed (e.g. anytime someone sent a message). Sending 20 messages quickly could cause the heap to go from 60mb memory usage to >1gb, and in many cases crash the browser. After updating to this alpha version of the package, I can see very clear garbage collection cycles with heap memory peaking at ~300mb.Note: @mxstbr we still have some perf issues for people sending messages very quickly, but this is likely our application code and a result of many async events happening in our chat input. I hope #4472 will help with this :)