This repository has been archived by the owner on Oct 11, 2022. It is now read-only.
Upgrade to [email protected] #4533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements query parsing and validation caching, reference apollographql/apollo-server#2111, and should thusly provide a nice speedup for our frontend's queries!
brianlovin
approved these changes
Jan 10, 2019
|
Throw it on alpha! It does the parsing and caching out of the box? Or do we have to enable that? |
|
Good question, I'm not 100% sure as the code comments say it's enabled by default, but the tests say it's disabled by default 😅 /cc @martijnwalraven |
|
@abernix answered my on Slack, this is enabled by default! Deploying to api.alpha |
|
After a short, fine trial run on alpha this is live on production. Not seeing any particularly big speedups yet, but it also doesn't hurt:
Going to try increasing the cache limit next week and seeing whether that makes for a more noticeable impact! |
|
Reassessing after a couple days in prod, it seems to have helped @abernix! p99 response time over:
👍 |
abernix
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jan 15, 2019
The parsed/validated cache store is on by default. While it could be disabled, in theory, it cannot be disabled since its an internal property of the request pipeline processor class. See confusion here: withspectrum/spectrum#4533 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
This implements query parsing and validation caching, reference apollographql/apollo-server#2111, and should thusly provide a nice speedup for our frontend's queries!
Since it's an alpha version, we should ship it to alpha.spectrum first, make sure nothing breaks and only then release to production and keep a close eye on the metrics too.