Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove yarn lock tracking from git #68

Merged
merged 1 commit into from
Oct 15, 2017
Merged

remove yarn lock tracking from git #68

merged 1 commit into from
Oct 15, 2017

Conversation

ronami
Copy link
Collaborator

@ronami ronami commented Oct 15, 2017

See facebook/create-react-app#2014 (comment) for more information on the intention behind this.

@ranyitz ranyitz self-requested a review October 15, 2017 13:41
ranyitz
ranyitz approved these changes Oct 15, 2017
View reviewed changes
Copy link
Collaborator

@ranyitz ranyitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, lock file is not suitable for our use case.

@ranyitz ranyitz merged commit b0e7998 into master Oct 15, 2017
@ranyitz ranyitz deleted the remove-yarn-lock branch October 15, 2017 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranyitz ranyitz ranyitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronami @ranyitz