Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted support in RN .59 #1421

Merged
merged 4 commits into from
Jun 3, 2019
Merged

Restricted support in RN .59 #1421

merged 4 commits into from
Jun 3, 2019

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Jun 2, 2019

Description:

Replaces PR #1416

Introduce required changes in order to have our demo app test suite successfully run on Android (with the necessary restrictions introduced by the RN issue).

  • Documentation will follow.
  • We nevertheless have to upgrade our visibility matcher in order to work around the RN issue, even though it's far from trivial.
  • This does not include an upgrade to the example projects.

@d4vidi d4vidi requested a review from rotemmiz as a code owner June 2, 2019 12:13
@d4vidi d4vidi requested review from LeoNatan and noomorph June 2, 2019 12:13
@d4vidi d4vidi changed the title Rn59 Restricted support in RN .59 Jun 2, 2019
@d4vidi d4vidi closed this Jun 2, 2019
@LeoNatan
Copy link
Contributor

LeoNatan commented Jun 2, 2019

?
Why close open close open

@d4vidi
Copy link
Collaborator Author

d4vidi commented Jun 2, 2019

because the CI is s***

@LeoNatan
Copy link
Contributor

LeoNatan commented Jun 2, 2019

You can trigger a build from the CI UI. Closing and reopening spams everyone attached with countless mails.

@d4vidi d4vidi self-assigned this Jun 3, 2019
@d4vidi d4vidi merged commit 47feb6c into master Jun 3, 2019
@d4vidi d4vidi mentioned this pull request Jun 3, 2019
2 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2019
@LeoNatan LeoNatan deleted the rn59 branch July 11, 2019 09:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants