feat: add duration and point (optional) parameters for longPress() action.
#4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafkorem
commented
Apr 29, 2024
asafkorem
commented
Apr 29, 2024
asafkorem
commented
Apr 29, 2024
detox/android/detox/src/main/java/com/wix/detox/espresso/action/DetoxMultiTap.kt
Show resolved
Hide resolved
asafkorem
commented
Apr 30, 2024
noomorph
requested changes
Apr 30, 2024
| ) | ||
| } | ||
| ); | ||
| return t.functionDeclaration( |
There was a problem hiding this comment.
While the overload generation is a brilliant mechanism and this is worth its own pull request, can we stop for a a second and discuss if a DTO argument could be a better idea, still?
There was a problem hiding this comment.
I want to align with the current longPress(duration) API we have (iOS-only)
There was a problem hiding this comment.
we can, possibly, enable both DTO and duration only but it feels a bit dirty.
also, it makes sense to align with tap({x: number, y: number}) for the point param.
asafkorem
force-pushed
the
feat/long-press-point
branch
from
5536c07
to
7f1aa93
Compare
d4vidi
reviewed
May 8, 2024
detox/android/detox/src/main/java/com/wix/detox/espresso/action/common/TapEvents.kt
Outdated
Show resolved
Hide resolved
detox/android/detox/src/main/java/com/wix/detox/espresso/action/DetoxCustomTapper.kt
Show resolved
Hide resolved
|
Released with Detox 20.21.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces optional parameters for the
longPress()action on both iOS and Android:duration: number: Specifies the duration of the long press (in ms). This parameter was previously supported on iOS but has now been extended to Android.point: {x: number, y: number}: Defines the position of the long press within the element's coordinate space.Documentation has been updated accordingly, and relevant end-to-end tests have been added.