Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added detoxReuse option #45

Closed
wants to merge 1 commit into from
Closed

added detoxReuse option #45

wants to merge 1 commit into from

Conversation

doronpr
Copy link
Contributor

@doronpr doronpr commented Oct 12, 2016

No description provided.

@LeoNatan
Copy link
Contributor

@rotemmiz Can we add this to Detox CLI?

@rotemmiz
Copy link
Member

Sorry for taking too long to respond to this. I really like this feature and I believe it has great value for dev flow.
This is an old pull request, and code was changed significantly since the PR was first submitted.

In order to support this feature, we can use relaunchApp with different params.

Simulator.js

  async prepare() {
    this._simulatorUdid = await this._fbsimctl.list(this._deviceConfig.name);
    this._bundleId = await this._getBundleIdFromApp(this._deviceConfig.binaryPath);
    await this._fbsimctl.boot(this._simulatorUdid);
    await this.relaunchApp({delete: true});
  }

@doronpr, do you think you can resubmit this PR ?
Huge thanks!

@doronpr
Copy link
Contributor Author

doronpr commented Apr 4, 2017

closing in favour of #105

@doronpr doronpr closed this Apr 4, 2017
@rotemmiz rotemmiz deleted the app-reuse branch June 8, 2017 11:51
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants