fix custom stylesheet for commonjs #2428
Open
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suneox
force-pushed
the
update-custom-stylesheet
branch
from
b78042b
to
6704490
Compare
suneox
force-pushed
the
update-custom-stylesheet
branch
from
6704490
to
1796cc7
Compare
Inbal-Tish
reviewed
Jul 23, 2024
src/agenda/reservation-list/style.ts
Outdated
| @@ -37,6 +38,6 @@ export default function styleConstructor(theme: Theme = {}) { | |||
| indicator: { | |||
| marginTop: 80 | |||
| }, | |||
| ...(theme['stylesheet.agenda.list'] || {}) | |||
| ...get(theme, 'stylesheet.agenda.list', {}) | |||
There was a problem hiding this comment.
Why 'get' and not optional chaining?
There was a problem hiding this comment.
The theme is a literal object, so we cannot use optional chaining syntax to access its properties.
There was a problem hiding this comment.
The theme is a typed object, you can do ...theme?.stylesheet?.agenda?.main
There was a problem hiding this comment.
@Inbal-Tish i've updated have you got any feedback on the latest change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For common js can not get custom style with the current syntax