-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,7 +87,7 @@ export class LayoutTreeCrawler { | |
} | ||
|
||
_applyButtonsStyle(buttons, style) { | ||
if (buttons) { | ||
if (_.isArray(buttons)) { | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
guyca
Collaborator
|
||
buttons.forEach((button) => { | ||
_.merge(button, style); | ||
}); | ||
|
When doing TypeScript you have to type the function parameters. What is the point of using TS if we are not typing stuff? @guyca @yogevbd Should this project have rule that there are no implicit
any
?