Skip to content

Commit

Permalink
merging buttons fix
Browse files Browse the repository at this point in the history
  • Loading branch information
yogevbd committed Aug 7, 2018
1 parent e3b4d15 commit 74077bb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/src/commands/LayoutTreeCrawler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class LayoutTreeCrawler {
}

_applyButtonsStyle(buttons, style) {
if (buttons) {
if (_.isArray(buttons)) {

This comment has been minimized.

Copy link
@henrikra

henrikra Aug 7, 2018

Contributor

When doing TypeScript you have to type the function parameters. What is the point of using TS if we are not typing stuff? @guyca @yogevbd Should this project have rule that there are no implicit any?

This comment has been minimized.

Copy link
@guyca

guyca Aug 7, 2018

Collaborator

We haven't had a chance to complete the switch to TypeScript and add interfaces to all classes, there was a PR which did that but it broke a few things so we had to revert. We'll merge it back after we fix it.

This comment has been minimized.

Copy link
@henrikra

henrikra Aug 7, 2018

Contributor

Is this also the reason that when I am developing my app with v2 that most of the params are just any?

This comment has been minimized.

Copy link
@henrikra

henrikra Aug 7, 2018

Contributor

Also @guyca can you link the PR you are talking about?

buttons.forEach((button) => {
_.merge(button, style);
});
Expand Down

0 comments on commit 74077bb

Please sign in to comment.