Fix topBar.title.component fill alignment (#5044)

* Fix topBar.title.component fill alignment * Lock react-native-ui-lib version
wix · Apr 30, 2019 · 9f439da · 9f439da
1 parent 0e8880d
commit 9f439da
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/lib/ios/RNNReactView.h b/lib/ios/RNNReactView.h
@@ -10,6 +10,6 @@ typedef void (^RNNReactViewReadyCompletionBlock)(void);
 @property (nonatomic, copy) void (^rootViewDidChangeIntrinsicSize)(CGSize intrinsicSize);
 @property (nonatomic, copy) RNNReactViewReadyCompletionBlock reactViewReadyBlock;
 
-- (void)setAlignment:(NSString *)alignment;
+- (void)setAlignment:(NSString *)alignment inFrame:(CGRect)frame;
 
 @end
diff --git a/lib/ios/RNNReactView.m b/lib/ios/RNNReactView.m
@@ -40,9 +40,10 @@ - (void)rootViewDidChangeIntrinsicSize:(RCTRootView *)rootView {
 	}
 }
 
-- (void)setAlignment:(NSString *)alignment {
+- (void)setAlignment:(NSString *)alignment inFrame:(CGRect)frame {
 	if ([alignment isEqualToString:@"fill"]) {
 		self.sizeFlexibility = RCTRootViewSizeFlexibilityNone;
+		[self setFrame:frame];
 	} else {
 		self.sizeFlexibility = RCTRootViewSizeFlexibilityWidthAndHeight;
 		__weak RNNReactView *weakSelf = self;

diff --git a/lib/ios/RNNViewControllerPresenter.m b/lib/ios/RNNViewControllerPresenter.m
@@ -167,7 +167,7 @@ - (void)setCustomNavigationTitleView:(RNNNavigationOptions *)options perform:(RN
 		_customTitleView = (RNNReactView*)[_componentRegistry createComponentIfNotExists:options.topBar.title.component parentComponentId:viewController.layoutInfo.componentId reactViewReadyBlock:readyBlock];
 		_customTitleView.backgroundColor = UIColor.clearColor;
 		NSString* alignment = [options.topBar.title.component.alignment getWithDefaultValue:@""];
-		[_customTitleView setAlignment:alignment];
+		[_customTitleView setAlignment:alignment inFrame:viewController.navigationController.navigationBar.frame];
 
 		viewController.navigationItem.titleView = nil;
 		viewController.navigationItem.titleView = _customTitleView;

diff --git a/package.json b/package.json
@@ -61,7 +61,7 @@
     "@types/react-test-renderer": "16.x.x",
     "jsc-android": "236355.x.x",
     "detox": "12.1.x",
-    "react-native-ui-lib": "3.x.x",
+    "react-native-ui-lib": "3.24.2",
     "handlebars": "4.x.x",
     "jest": "23.x.x",
     "metro-react-native-babel-preset": "0.50.0",