Catch rare RuntimeException in setRoot when waitForRender = true (#5428)

When setRoot is called with `waitForRender=true`, check if the root view is destroyed before displaying it.
wix · Sep 5, 2019 · b048581 · b048581
1 parent a99e138
commit b048581
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/android/app/src/main/java/com/reactnativenavigation/presentation/RootPresenter.java b/lib/android/app/src/main/java/com/reactnativenavigation/presentation/RootPresenter.java
@@ -42,8 +42,12 @@ public void setRoot(ViewController root, Options defaultOptions, CommandListener
         if (options.animations.setRoot.waitForRender.isTrue()) {
             root.getView().setAlpha(0);
             root.addOnAppearedListener(() -> {
-                root.getView().setAlpha(1);
-                animateSetRootAndReportSuccess(root, listener, options);
+                if (root.isDestroyed()) {
+                    listener.onError("Could not set root - Waited for the view to become visible but it was destroyed");
+                } else {
+                    root.getView().setAlpha(1);
+                    animateSetRootAndReportSuccess(root, listener, options);
+                }
             });
         } else {
             animateSetRootAndReportSuccess(root, listener, options);