-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stack declared children crash on duplicate id (#7074)
# Issue Calling setRoot with children that have the same ids, caused pop to crash, not aligned with `Navigation.push` behaviour ```javascript setRoot = async () => await Navigation.setRoot({ root: { stack: { id: 'stack', children: [ { component: { id: 'component', name: Screens.A, }, }, { component: { id: 'component', name: Screens.A, }, }, ], }, }, }); ``` # Fix Since such behaviour cannot be ignored, pop will always fail if we just ignore the ids, the fix is to be aligned with `push` command.
- Loading branch information
Showing
3 changed files
with
18 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters