[v2] Tried to create view after it has already been destroyed #3767

pibo · 2018-08-14T21:19:30Z

My app users are complaining about random crashes on Android. I have Crashlytics installed and I verified by using user and time filters that this crashes are caused by the following error:

I can't reproduce the problem in the Android simulator and it seems Android exclusive, as it appears. Can anyone help me what might be happening?
Thanks in advance.

Environment

React Native Navigation version: 2.0.2377
React Native version: 0.55.4
Platform(s) (iOS, Android, or both?): Android
Device info (Simulator/Device? OS version? Debug/Release?): Only device, apparently

nezaidu · 2018-08-17T13:34:38Z

same

nezaidu · 2018-08-17T13:44:19Z

somebody pls remember me to show you how to reproduce, i know how, very busy right now, might forget

starzle · 2018-08-26T21:29:03Z

See the same crash in Android only. In my case, it happens when a child screen is popping (the pop animation is running) when the setRoot() method is called. If I set the pop animation's duration to 0, it works without any problem. So I think the pop animation is the culprit here.

Hope this information can help you resolve the issue.

guyca · 2018-08-27T06:17:32Z

Unfortunately I can't fix this one without a reproduction, @nezaidu ?

reganperkins · 2018-08-29T00:00:10Z

getting the same thing but no consistent way of reproducing this.

guyca · 2018-08-29T13:07:57Z

@starzle Have you tried awaiting the pop command so root is set after pop completes?

starzle · 2018-08-29T15:58:30Z

@guyca In our case, the setRoot is called when componentDidAppear is triggered. And apparently, componentDidAppear is triggered before the pop animation ends. So we don't have a place where we can await the pop.

But if we simply add a delay to the setRoot call, then as long as the delay is long enough to make sure pop animation is already finish (onAnimationEnd called if I am correct) when setRoot is called, then the crash goes away. In short, pop's onAnimationEnd needs to be called before setRoot.

Hope this info can help you.

suetming · 2018-09-01T06:13:07Z

after add code push relative,
code push update restart app, android app will crash,
logcat console out put this log

java.lang.RuntimeException: Tried to create view after it has already been destroyed

zirtuedeveloper · 2018-09-11T11:35:46Z

i have same issue

zirtuedeveloper · 2018-09-11T11:50:39Z

componentDidMount(){


 
  this._getDeviceToken();

  

  FCM.getInitialNotification().then(notif => {
    console.log(notif,'notif tapped')
    if (notif.gotoActivity==="dashboard") {
      startMainTab(2);
      return;
    }
    else if (notif.gotoActivity==="activity") {
      startMainTab(0);
      return;
    }

  
  });

  
  FCM.on(FCMEvent.Notification, this.handleNotification);


  this.tokenToState();

  
  

}

reganperkins · 2018-09-19T19:45:11Z

this also occurs when you have a root view, navigate to a new view with pushTo from a modal and then try to setStackRoot within the main application.

haggholm · 2018-09-19T21:37:30Z

To add to my colleague @reganperkins above, our error is the same but the stacktrace does not seem entirely identical.

09-19 14:13:26.303 5362-5362/co.elk.rn D/ERROR: java.lang.RuntimeException: Tried to create view after it has already been destroyed
        at com.reactnativenavigation.viewcontrollers.ViewController.getView(ViewController.java:153)
        at com.reactnativenavigation.viewcontrollers.ViewController.lambda$runOnPreDraw$2$ViewController(ViewController.java:266)
        at com.reactnativenavigation.viewcontrollers.ViewController$$Lambda$2.run(Unknown Source)
        at com.reactnativenavigation.utils.UiUtils$1.onPreDraw(UiUtils.java:27)
        at android.view.ViewTreeObserver.dispatchOnPreDraw(ViewTreeObserver.java:944)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2205)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1254)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6337)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:874)
        at android.view.Choreographer.doCallbacks(Choreographer.java:686)
        at android.view.Choreographer.doFrame(Choreographer.java:621)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:860)
        at android.os.Handler.handleCallback(Handler.java:751)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:154)
        at android.app.ActivityThread.main(ActivityThread.java:6119)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

We managed to find a workaround that may (or may not!) clarify the situation. As she was saying, the control flow in our scenario is this:

Start on a root view.
Open a modal (as it happens, to create a new item).
From the modal, navigate via pushTo() to a new view (the new item).
From the new item, navigate via setStackRoot() to the root component. (Of course, in this specific scenario, we could pop, but the code is more generic.)

The workaround: Close the modal before pushing the new view, deferring the push using setImmediate(). Now, for some reason, it no longer crashes. Perhaps the open modal does something strange to the stack?

DaneEveritt · 2018-10-11T00:53:02Z

I can confirm this happening as well. In my case I'm calling a setRoot on a login screen to bump an already logged in user into the app.

Heres the stack from the crash, only affects android devices.

E/AndroidRuntime: FATAL EXCEPTION: main
                  Process: com.lawnlove.provider, PID: 17401
                  java.lang.RuntimeException: Tried to create view after it has already been destroyed
                      at com.reactnativenavigation.viewcontrollers.ViewController.getView(ViewController.java:152)
                      at com.reactnativenavigation.viewcontrollers.ParentController.getView(ParentController.java:63)
                      at com.reactnativenavigation.viewcontrollers.stack.StackController.lambda$push$4$StackController(StackController.java:157)
                      at com.reactnativenavigation.viewcontrollers.stack.StackController$$Lambda$4.run(Unknown Source:0)
                      at com.reactnativenavigation.anim.NavigationAnimator$1.onAnimationEnd(NavigationAnimator.java:64)
                      at android.animation.Animator$AnimatorListener.onAnimationEnd(Animator.java:552)
                      at android.animation.AnimatorSet.endAnimation(AnimatorSet.java:1293)
                      at android.animation.AnimatorSet.doAnimationFrame(AnimatorSet.java:1079)
                      at android.animation.AnimationHandler.doAnimationFrame(AnimationHandler.java:146)
                      at android.animation.AnimationHandler.-wrap2(Unknown Source:0)
                      at android.animation.AnimationHandler$1.doFrame(AnimationHandler.java:54)
                      at android.view.Choreographer$CallbackRecord.run(Choreographer.java:909)
                      at android.view.Choreographer.doCallbacks(Choreographer.java:723)
                      at android.view.Choreographer.doFrame(Choreographer.java:655)
                      at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:897)
                      at android.os.Handler.handleCallback(Handler.java:789)
                      at android.os.Handler.dispatchMessage(Handler.java:98)
                      at android.os.Looper.loop(Looper.java:164)
                      at android.app.ActivityThread.main(ActivityThread.java:6944)
                      at java.lang.reflect.Method.invoke(Native Method)
                      at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
                      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)
E/UncaughtException: java.lang.RuntimeException: Tried to create view after it has already been destroyed
                         at com.reactnativenavigation.viewcontrollers.ViewController.getView(ViewController.java:152)
                         at com.reactnativenavigation.viewcontrollers.ParentController.getView(ParentController.java:63)
                         at com.reactnativenavigation.viewcontrollers.stack.StackController.lambda$push$4$StackController(StackController.java:157)
                         at com.reactnativenavigation.viewcontrollers.stack.StackController$$Lambda$4.run(Unknown Source:0)
                         at com.reactnativenavigation.anim.NavigationAnimator$1.onAnimationEnd(NavigationAnimator.java:64)
                         at android.animation.Animator$AnimatorListener.onAnimationEnd(Animator.java:552)
                         at android.animation.AnimatorSet.endAnimation(AnimatorSet.java:1293)
                         at android.animation.AnimatorSet.doAnimationFrame(AnimatorSet.java:1079)
                         at android.animation.AnimationHandler.doAnimationFrame(AnimationHandler.java:146)
                         at android.animation.AnimationHandler.-wrap2(Unknown Source:0)
                         at android.animation.AnimationHandler$1.doFrame(AnimationHandler.java:54)
                         at android.view.Choreographer$CallbackRecord.run(Choreographer.java:909)
                         at android.view.Choreographer.doCallbacks(Choreographer.java:723)
                         at android.view.Choreographer.doFrame(Choreographer.java:655)
                         at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:897)
                         at android.os.Handler.handleCallback(Handler.java:789)
                         at android.os.Handler.dispatchMessage(Handler.java:98)
                         at android.os.Looper.loop(Looper.java:164)
                         at android.app.ActivityThread.main(ActivityThread.java:6944)
                         at java.lang.reflect.Method.invoke(Native Method)
                         at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
                         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)

zsajjad · 2018-11-10T09:23:12Z

Any update on this @guyca ?

makirby · 2018-11-12T18:46:27Z

Wrapping the setStackroot calls with InteractionManager.runAfterInteractions, solved this for me.

zsajjad · 2018-11-12T20:01:16Z

@makirby can you please share a snippet for the solution?

makirby · 2018-11-12T21:09:48Z

Basically where we were making a setStackRoot call soon after another push in a modal stack, I would do something like this.

 InteractionManager.runAfterInteractions(() => {
                    Navigation.setStackRoot(STACK_IDS.main, {
                      component: { name: SCREEN_MAP.Home },
                    })
                  })

stale · 2018-12-12T22:02:58Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

dozoisch · 2018-12-12T22:04:46Z

probably not stale

kyle-ssg · 2019-03-28T10:06:39Z

Can confirm I've just started facing this, thanks for the catch @zabojad 👍. This seems to be Android only.

Edit: This was actually my own fault (although the hard crash without indication wasn't ideal). This is also replicable on android if you try to push to a screen twice from the same component id. iOS side silently deals with it.

bahmannejati · 2019-03-30T13:38:22Z

Here is my code for reproduce this issue & also found tricks to solve the issue :

for(let i = 0; i < 20; i++){
	Navigation.setRoot({
		root: {
			component: {
				id: SCREENS.HUB,
				name: SCREENS.HUB,

				passProps: {
				}
			}
		}
	});
	Navigation.setRoot({
		root: {
			sideMenu: {
				center: {
					stack: {
						children: [
							{
								component: {
									id: SCREENS.HOME,
									name: SCREENS.HOME,
								}
							}
						],
					}
				},
				right: {
					component: {
						id: SCREENS.SIDE_MENU,
						name: SCREENS.SIDE_MENU,
					}
				}
			}
		}
	});
}

I placed 20 in for() to make sure that error happens, because this issue doesn't happen always.
After about 3 days and testing many solutions (that no one worked correctly, even i made a task queue system for managing Navigation methods priority in a good way) i found that cant fix that permanently.

But we have two choice to get rid out of that:

1. Making app layout structure with just 1 Navigation.setRoot() and then use .push() .pop() .popToRoot() to manage navigation, it should work but still is risky because i faced Tried to create... even in my first Navigation.setRoot()

2. Simply comment (or delete :) bellow line in ViewController.java:

if (isDestroyed) {
      throw new RuntimeException("Tried to create view after it has already been destroyed");
}

This worked for me without any problem, that is a quick TEMPORARY solution, not PERMANENTLY.

(ViewController.java is here : /node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/)

Zaporozhec7 · 2019-04-12T12:23:04Z

If I try use method 2. mentioned by @bahmannejati , I have segfault instead that exception

nilocoelhojunior · 2019-04-12T13:04:20Z

Sorry @varungupta85 for delay. In my case, I have two navigations one Stack and one with BotoomTabs. And to manage this navigation I have a Component with Redux. What happened was that this component was updated more than once by Redux and with that, the setRoot was also called and the app crashed.
The solution was to create an attribute in the state of the Component to control when to call the setRoot.

fodjan-philip · 2019-04-18T09:34:24Z

My app consists of BottomTabs containing stacks of screens. Whenever the BottomTab is changed, I call Navigation.popToRoot() for the tab that the user is leaving.

I can reproduce the crash by pushing a screen to the stack of a tab (with waitForRender in push animation) and then quickly changing to another tab and back.

It sounds like #4842 addressed that issue, but I am running v2.16.0 and still get the error.

guyca · 2019-04-18T11:06:22Z

@fliPmitKlammern Could you please push a branch with a reproduction in the playground app?

RuairiOliver · 2019-04-18T15:23:32Z

Got this today, going with commenting it out for now as suggested earlier

AugustoAleGon · 2019-05-11T15:37:08Z

This issue is still in Android. I got the same error but different logs tho:


Fatal Exception: java.lang.RuntimeException
Tried to create view after it has already been destroyed
com.reactnativenavigation.viewcontrollers.ViewController.getView (ViewController.java:165)
com.reactnativenavigation.viewcontrollers.ChildController.onViewBroughtToFront (ChildController.java:45)
com.reactnativenavigation.viewcontrollers.ChildControllersRegistry.onViewDisappear (ChildControllersRegistry.java:15)
com.reactnativenavigation.viewcontrollers.ChildController.onViewDisappear (ChildController.java:41)
com.reactnativenavigation.viewcontrollers.ComponentViewController.onViewDisappear (ComponentViewController.java:48)
com.reactnativenavigation.viewcontrollers.ViewController.destroy (ViewController.java:235)
com.reactnativenavigation.viewcontrollers.ChildController.destroy (ChildController.java:70)
com.reactnativenavigation.viewcontrollers.ComponentViewController.destroy (ComponentViewController.java:93)
com.reactnativenavigation.viewcontrollers.ParentController.destroy (ParentController.java:112)
com.reactnativenavigation.viewcontrollers.stack.StackController.destroy (StackController.java:138)
com.reactnativenavigation.viewcontrollers.navigator.Navigator.destroyRoot (Navigator.java:121)
com.reactnativenavigation.viewcontrollers.navigator.Navigator.destroyViews (Navigator.java:117)
com.reactnativenavigation.NavigationActivity.onReload (NavigationActivity.java:124)
com.reactnativenavigation.react.JsDevReloadHandler$$Lambda$1.run (Unknown Source:2)

turbix · 2019-05-19T07:02:26Z

The issue still reproduces on Android: after app start press back button and start app again -- crash occurs with same stack.

stale · 2019-12-21T07:10:42Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale · 2019-12-28T07:24:26Z

The issue has been closed for inactivity.

When popToRoot or popTo where called while a screen was pushed, at the end of the push animation RNN tried to destroy an already destroyed ViewController. Related to wix#3767

This PR includes a series of fixes that attempt to alleviate crashing when restarting the bundle on Android. - Use BB fork of react-native-restart package which contains a fix to the Android code - Wrap Navigation.setRoot() in fsapp inside runAfterInteractions which appears to help alleviate Navigation being clobbered on startup (inspired by wix/react-native-navigation#3767 (comment)) - Refactor tab logic in fsapp so that tabs are generated before setting them in the Navigator - Update tab schema to follow recommended format (wix/react-native-navigation#5096 (comment)) - Removed non-printable character from PirateShip initialization config - Removed setStackRoot() calls in PirateShip that were being used when authentication failed on app startup. These appeared to be clobbering Navigation when it was trying to initialize the app.

gigby · 2020-06-16T18:13:01Z

The issue still reproduces on Android: after app start press back button and start app again -- crash occurs with same stack.

This bug is still here (version 6.7.5)

avonipenti · 2021-01-08T14:13:04Z

Upgraded to fix the crashes but I still see the crashes in firebase.

marf · 2021-01-20T14:41:50Z

We still see the crash with version 7.8.4

dooleyb1 · 2021-02-23T09:47:24Z

Still seeing crashes occur in Crashlytics on app using "react-native-navigation": "7.9.0"

dooleyb1 · 2021-05-10T08:07:30Z

Any updates on this?

parth-koshta · 2022-05-10T15:13:28Z

This issue still exists in 7.27.1

TrustDec · 2022-09-23T04:00:03Z

This issue still exists in 7.27.1、7.28.1、7.29.0

This PR includes a series of fixes that attempt to alleviate crashing when restarting the bundle on Android. - Use BB fork of react-native-restart package which contains a fix to the Android code - Wrap Navigation.setRoot() in fsapp inside runAfterInteractions which appears to help alleviate Navigation being clobbered on startup (inspired by wix/react-native-navigation#3767 (comment)) - Refactor tab logic in fsapp so that tabs are generated before setting them in the Navigator - Update tab schema to follow recommended format (wix/react-native-navigation#5096 (comment)) - Removed non-printable character from PirateShip initialization config - Removed setStackRoot() calls in PirateShip that were being used when authentication failed on app startup. These appeared to be clobbering Navigation when it was trying to initialize the app. brandingbrand-source-id: 42d0e5126eb8c5594ca4bf6c17b95106f487e4fa

guyca added user: more info needed platform: Android v2 labels Aug 27, 2018

guyca added type: accepted/bug Wix and removed user: more info needed labels Sep 2, 2018

guyca added this to the 2.x.x Complete Rewrite (full feature parity) milestone Sep 2, 2018

rajivshah3 mentioned this issue Dec 3, 2018

java.lang.RuntimeException: Tried to create view after it has already been destroyed iotaledger/trinity-wallet#538

Closed

stale bot added the 🏚 stale label Dec 12, 2018

stale bot removed the 🏚 stale label Dec 12, 2018

cayleyh mentioned this issue Jul 12, 2019

[iOS] ExternalComponents with a presenter property crash with Unknown selector error calling applyOptionsOnWillMoveToParentViewController #5279

Closed

guyca removed the 📌 pinned label Nov 21, 2019

stale bot added the 🏚 stale label Dec 21, 2019

stale bot closed this as completed Dec 28, 2019

tellodaniel mentioned this issue Jan 15, 2020

RuntimeException Tried to create view after it has already been destroyed #5689

Closed

anushnair mentioned this issue Apr 1, 2020

PRODSUP-497 | Android | Changes recommended as part of issue 3767 in … anushnair/react-native-navigation#1

Merged

bweissbart mentioned this issue May 7, 2020

fix: address android bundle restart crashes brandingbrand/flagship#1360

Merged

[v2] Tried to create view after it has already been destroyed #3767

[v2] Tried to create view after it has already been destroyed #3767

Comments

pibo commented Aug 14, 2018

Environment

nezaidu commented Aug 17, 2018

nezaidu commented Aug 17, 2018

starzle commented Aug 26, 2018

guyca commented Aug 27, 2018

reganperkins commented Aug 29, 2018

guyca commented Aug 29, 2018

starzle commented Aug 29, 2018

suetming commented Sep 1, 2018 • edited Loading

zirtuedeveloper commented Sep 11, 2018

zirtuedeveloper commented Sep 11, 2018

reganperkins commented Sep 19, 2018 • edited Loading

haggholm commented Sep 19, 2018

DaneEveritt commented Oct 11, 2018

zsajjad commented Nov 10, 2018

makirby commented Nov 12, 2018 • edited Loading

zsajjad commented Nov 12, 2018

makirby commented Nov 12, 2018

stale bot commented Dec 12, 2018

dozoisch commented Dec 12, 2018

kyle-ssg commented Mar 28, 2019 • edited Loading

bahmannejati commented Mar 30, 2019 • edited Loading

Zaporozhec7 commented Apr 12, 2019

nilocoelhojunior commented Apr 12, 2019

fodjan-philip commented Apr 18, 2019

guyca commented Apr 18, 2019

RuairiOliver commented Apr 18, 2019

AugustoAleGon commented May 11, 2019

turbix commented May 19, 2019

stale bot commented Dec 21, 2019

stale bot commented Dec 28, 2019

gigby commented Jun 16, 2020

avonipenti commented Jan 8, 2021

marf commented Jan 20, 2021

dooleyb1 commented Feb 23, 2021

dooleyb1 commented May 10, 2021

parth-koshta commented May 10, 2022

TrustDec commented Sep 23, 2022

suetming commented Sep 1, 2018 •

edited

Loading

reganperkins commented Sep 19, 2018 •

edited

Loading

makirby commented Nov 12, 2018 •

edited

Loading

kyle-ssg commented Mar 28, 2019 •

edited

Loading

bahmannejati commented Mar 30, 2019 •

edited

Loading