Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] showModal animation broken #5036

Closed
Dexwell opened this issue Apr 26, 2019 · 7 comments
Closed

[V2] showModal animation broken #5036

Dexwell opened this issue Apr 26, 2019 · 7 comments

Comments

@Dexwell
Copy link

Dexwell commented Apr 26, 2019

Issue Description

On the latest version, modals on iOS instantly show, while the dismiss animation does work.

Steps to Reproduce / Code Snippets / Screenshots

Navigation.showModal({
  component: {
    name: 'example.Screen'
  }
});

Environment

  • React Native Navigation version: 2.18.1
  • React Native version: 0.59.5
  • Platform(s) (iOS, Android, or both?): iOS confirmed
@guyca
Copy link
Collaborator

guyca commented Apr 28, 2019

Hey @Dexwell , were you able to reproduce this in the playground app?

@Dexwell
Copy link
Author

Dexwell commented Apr 29, 2019

I can't get the Playground app to build—is there a guide to this?

@3luyka
Copy link

3luyka commented Apr 29, 2019

same here :/

@guyca
Copy link
Collaborator

guyca commented Apr 30, 2019

I found one way to reproduce it:

  1. Show modal
  2. Show another modal
    Second modal isn't animated 🤷‍♂

@cjroth
Copy link

cjroth commented May 2, 2019

I'm having the same issue.

@3luyka
Copy link

3luyka commented May 10, 2019

I've replaced

Navigation.showModal({
  component: {
    name: 'example.Screen'
  }
});

with

Navigation.showModal({
  stack: {
    children: [
      {
        component: {
          name: 'example.Screen',
        },
      },
    ],
  },
});

and animation works as expected. (might be helpful)

@Dexwell
Copy link
Author

Dexwell commented May 10, 2019

Can confirm @3luyka's solution works; would be great if both ways worked and not every showModal call will have to be updated though.

vshkl pushed a commit to vshkl/react-native-navigation that referenced this issue Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants