Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not hidding bottomTabs after navigate to child and bugs title bar #6313

Closed
webforuse opened this issue Jun 16, 2020 · 0 comments · Fixed by #6314
Closed

not hidding bottomTabs after navigate to child and bugs title bar #6313

webforuse opened this issue Jun 16, 2020 · 0 comments · Fixed by #6314

Comments

@webforuse
Copy link

webforuse commented Jun 16, 2020

Issue Description

Steps to Reproduce / Code Snippets / Screenshots

  1. Set default options
    bottomTabs: {
    animate: true,
    drawBehind: false,
    visible: false,
    },

  2. Create root bottom tabs screen
    bottomTabs: {
    visible: true,
    animate: true,
    drawBehind: true,
    currentTabIndex: 0,
    titleDisplayMode: 'alwaysShow',
    },

  3. Navigate to child screen (with settings)
    bottomTabs: {
    visible: false,
    animate: true,
    drawBehind: true,
    },


Environment

  • React Native Navigation version: 6.7.3
  • React Native version: 0.62.2
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): Release/Debug

my code (sandbox)
https://github.com/webforuse/sandbox

Запись экрана 2020-06-14 в 18 51 51

guyca pushed a commit that referenced this issue Jun 16, 2020
`BottomTabsController.currentTabIndex` didn't get updated on pressing tabs which resulted in wrong option resolving and multiple styling bugs.

Closes #6310
Closes #6313
yogevbd added a commit that referenced this issue Jun 16, 2020
`BottomTabsController.currentTabIndex` didn't get updated on pressing tabs which resulted in wrong option resolving and multiple styling bugs.

Closes #6310
Closes #6313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant