-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared Element Transition does not transform Image correctly #6505
Comments
When animating images in shared element transition, we change their ScaleType to an InterpolatingScaleType. At the end of the animation we need to restore the ScaleType back to its original value but for some reason this doesn't seem to work. The current solution recursively find the original scale type used for the destination image. Related to #6505
When animating images in shared element transition, we change their ScaleType to an InterpolatingScaleType. At the end of the animation we need to restore the ScaleType back to its original value but for some reason this doesn't seem to work. The current solution recursively find the original scale type used for the destination image. Related to #6505
Can confirm that the issue also occurs with |
This is still not working properly. Any updates? |
@tastyqbit Are you talking about image transition with different |
@yogevbd Yes that is what I was asking about, thanks for the update :) Do you have any idea on the timeline? I am just in the process of upgrading a lot of libraries including react-native from 0.59 to 0.63 and RNN from v2 to v7 and maybe I wait instead of redo my workaround I made for v2 if its not too long |
In my case shared element only working for IOS,on android element just disappear. |
Closing this issue as the last messages don't provide substantial info to work with. If there are any more issues related to image transformations, we would greatly appreciate if you could open new issues with reproductions and we will look into them ASAP. |
@guyca Does that mean the "Animating between Images with different resizeModes" issue shown in the demo gifs above is solved? |
Progress
Issue Description
When using Shared Element Transitions to animate Images between Screens, the animation does not work in the following scenarios:
400 x 300
, destination image is440 x 300
.resizeMode
s.I've created a repro for this bug in a branch on my fork. This shows the first scenarios, change the resizeMode to
'contain'
to reproduce the second scenario.Steps to Reproduce / Code Snippets / Screenshots
Demo GIF
Environment
The text was updated successfully, but these errors were encountered: