Bugfix [iOS]: Fix Height of sidemenu when device orientation changes in iOS #4907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ight on orientation change
|
@guyca hey Guy, can you review this PR? |
yogevbd
approved these changes
Mar 31, 2019
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
…in iOS (wix#4907) * fixes noBorder issue with largeTitle * fixes issue that change navigationbar title color to default * - change drawerControllers subviews height to MMDrawerController`s height on orientation change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on iOS when device rotates to landscape or portrait orientation, drawer's left and right controllers subviews dont get height update. this pull request will force drawers subviews to get new heights.