Fix setStackRoot crash when called with the same id #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Stack’s root was set with an id of one of the Stack’s current children, there was a crash since the wrong elements were removed from the stack. This commit fixes this by creating a new stack when setStackRoot is called, and destroying all ViewControllers from the previous Stack. Fixes #5117
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
When a Stack’s root was set with an id of one of the Stack’s current children, there was a crash since the wrong elements were removed from the stack. This commit fixes this by creating a new stack when setStackRoot is called, and destroying all ViewControllers from the previous Stack. Fixes wix#5117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Stack’s root was set with an id of one of the Stack’s current children, there was a crash
since the wrong elements were removed from the stack.
This commit fixes this by creating a new (underlying) stack when setStackRoot is called, and destroying all ViewControllers from the previous Stack.
Fixes #5117