Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support centered bottomTab icons using bottomTabs.titleDisplayMode option #5667

Merged
merged 7 commits into from
Nov 24, 2019
Merged

Support centered bottomTab icons using bottomTabs.titleDisplayMode option #5667

merged 7 commits into from
Nov 24, 2019

Conversation

yogevbd
Copy link
Collaborator

@yogevbd yogevbd commented Nov 20, 2019

Passing titleDisplayMode: 'alwaysHide' will both hide the bottomTab title text and center the bottomTab icon on iOS.

options: {
  bottomTabs: {
    titleDisplayMode: 'alwaysHide'
   }
}

guyca
guyca requested changes Nov 24, 2019
View reviewed changes
lib/ios/UITabBarController+RNNOptions.m Outdated Show resolved Hide resolved
lib/ios/UITabBar+centered.m Outdated Show resolved Hide resolved
lib/ios/UITabBar+centered.m Outdated Show resolved Hide resolved
guyca
guyca requested changes Nov 24, 2019
View reviewed changes
lib/ios/UITabBar+centered.m Outdated Show resolved Hide resolved
@yogevbd yogevbd requested a review from guyca November 24, 2019 13:31
guyca
guyca requested changes Nov 24, 2019
View reviewed changes
lib/ios/RNNBottomTabsPresenter.m Outdated Show resolved Hide resolved
@yogevbd yogevbd requested a review from guyca November 24, 2019 14:05
@yogevbd yogevbd merged commit 26d3d82 into master Nov 24, 2019
@yogevbd yogevbd deleted the centeredBottomTabImages branch November 24, 2019 14:51
vshkl pushed a commit to vshkl/react-native-navigation that referenced this pull request Feb 5, 2020
@yogevbd @vshkl
Support centered bottomTab icons using bottomTabs.titleDisplayMode op…
70db7dc 
…tion (wix#5667)

* Support centered bottomTab icons using bottomTabs.titleDisplayMode option

* Improve readability, better namings

* Rename setTabItemImagesCentered to centerTabItems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyca guyca guyca approved these changes

Assignees
No one assigned
Labels
platform: iOS type: accepted/enhancement Wix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yogevbd @guyca