Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TitleState showWhenActiveForce option for bottomTabs #5814

Merged
merged 5 commits into from
Jan 9, 2020
Merged

Added TitleState showWhenActiveForce option for bottomTabs #5814

merged 5 commits into from
Jan 9, 2020

Conversation

BenJeau
Copy link
Contributor

@BenJeau BenJeau commented Dec 30, 2019

Android Bottom Navigation Tabs

Related Issue
Closes #5800

Description
When playing around with AHBottomNavigation demo app, in order to only show to title of the active bottom tab when there's three tabs, the TitleState needs to be set to SHOW_WHEN_ACTIVE_FORCE.

Adding these changes allow for this behavior in RNN, but when I'm clicking on a tab, the app dies. I only added this change to the playground app, to the bottomTabs root in app.js:

options: {
  bottomTabs: {
    titleDisplayMode: 'showWhenActiveForce'
  }
}

Would anyone have a pointer on how to fix this or how to figure out what's wrong?

@guyca
Copy link
Collaborator

guyca commented Jan 6, 2020

@BenJeau, I just published version version 3.0.9 - can you please try it and see if it fixes the crash when changing tabs?

@BenJeau
Copy link
Contributor Author

BenJeau commented Jan 7, 2020

Just rebased with master (ignore the multiple force-pushed, it's weird rebased a fork), but the app still crashed when adding this option titleDisplayMode: 'showWhenActiveForce' to bottomTabs and clicking a tab, but if you look, it correctly displays at least

screenshot

@guyca
Copy link
Collaborator

guyca commented Jan 7, 2020

@BenJeau Have you tried using version 3.0.9 of https://github.com/wix-playground/ahbottomnavigation ? You can change it here and recompile

@BenJeau
Copy link
Contributor Author

BenJeau commented Jan 8, 2020

Yep it works now and doesn't crash! Will push a commit soon

@BenJeau BenJeau changed the title [WIP] Added TitleState showWhenActiveForce option for bottomTabs Added TitleState showWhenActiveForce option for bottomTabs Jan 8, 2020
@guyca guyca merged commit cf18e2d into wix:master Jan 9, 2020
vshkl pushed a commit to vshkl/react-native-navigation that referenced this pull request Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

titleDisplayMode doesn't work with three bottom tabs
2 participants