Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if UIBarButtonItem is RNNUIBarButtonItem #5850

Merged
merged 1 commit into from
Jan 15, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions lib/ios/RNNNavigationButtons.m
Original file line number Diff line number Diff line change
Expand Up @@ -73,23 +73,33 @@ - (NSArray *)currentButtons {
}

- (void)componentDidAppear {
for (RNNUIBarButtonItem* barButtonItem in [self currentButtons]) {
[barButtonItem notifyDidAppear];
for (UIBarButtonItem* barButtonItem in [self currentButtons]) {
if ([self isRNNUIBarButton:barButtonItem]) {
[(RNNUIBarButtonItem *)barButtonItem notifyDidAppear];
}
}
}

- (void)componentDidDisappear {
for (RNNUIBarButtonItem* barButtonItem in [self currentButtons]) {
[barButtonItem notifyDidDisappear];
for (UIBarButtonItem* barButtonItem in [self currentButtons]) {
if ([self isRNNUIBarButton:barButtonItem]) {
[(RNNUIBarButtonItem *)barButtonItem notifyDidDisappear];
}
}
}

- (void)notifyButtonsDidAppear:(NSArray *)barButtonItems {
for (RNNUIBarButtonItem* barButtonItem in barButtonItems) {
[barButtonItem notifyDidAppear];
for (UIBarButtonItem* barButtonItem in barButtonItems) {
if ([self isRNNUIBarButton:barButtonItem]) {
[(RNNUIBarButtonItem *)barButtonItem notifyDidAppear];
}
}
}

- (BOOL)isRNNUIBarButton:(UIBarButtonItem *)barButtonItem {
return [barButtonItem isKindOfClass:[RNNUIBarButtonItem class]];
}

- (void)clearPreviousButtonViews:(NSArray<UIBarButtonItem *> *)newButtons oldButtons:(NSArray<UIBarButtonItem *> *)oldButtons {
NSArray<UIBarButtonItem *>* removedButtons = [oldButtons difference:newButtons withPropertyName:@"customView"];

Expand Down